Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Day 1 Afternoon Exercises Solution Incomplete #520

Closed
bngoalie opened this issue Mar 22, 2023 · 3 comments
Closed

Day 1 Afternoon Exercises Solution Incomplete #520

bngoalie opened this issue Mar 22, 2023 · 3 comments
Labels
bug Something isn't working good first issue Good for newcomers help wanted Extra attention is needed

Comments

@bngoalie
Copy link

For "Designing a Library", the main still has commented-out code.

For "Iterators and Ownership", there is no discussion on the questions proposed in the exercise.

@mgeisler mgeisler added bug Something isn't working good first issue Good for newcomers labels Aug 11, 2023
@mgeisler mgeisler added the help wanted Extra attention is needed label Aug 24, 2023
@inglorion
Copy link

inglorion commented Aug 25, 2023

I think the description needs to be updated.

"Iterators and Ownership" is now in Day 2, Morning.

I don't see "Designing a Library" in the exercises. Is this in "Storing Books" (Day 2) now?

With the updated description, I can take a look. @mgeisler, can you confirm the answers to my questions?

@mgeisler
Copy link
Collaborator

mgeisler commented Aug 27, 2023

Hi @inglorion! Thanks for the interest! Yes, you're spot on: we recently moved things around in #913.

I think that's all from a quick look at the pages, but there might very well be more small problems here — a good starting point would actually be #1065, which is just about making the solutions easier to read.

@fw-immunant
Copy link
Collaborator

I don't think these problems exist anymore.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working good first issue Good for newcomers help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

4 participants