Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Why EarlGrey doesn't use submodule to get fishhook and OCMock? #357

Open
Arcank opened this issue Nov 29, 2016 · 4 comments
Open

Why EarlGrey doesn't use submodule to get fishhook and OCMock? #357

Arcank opened this issue Nov 29, 2016 · 4 comments
Assignees

Comments

@Arcank
Copy link
Contributor

Arcank commented Nov 29, 2016

Currently, one needs to run (directly or indirectly) the script setup-earlgrey.sh to download them.
Why can't it be achieved via submodules? It would make setup easier.

@tirodkar
Copy link
Collaborator

That's a good point. We could actually add submodules and remove those sections entirely from the setup file.

However, one reason we do it is because on building EarlGrey, we download these dependencies if they're not already present. We could however add git submodule update --recursive to the setup step and this would automate this as well.

@Arcank
Copy link
Contributor Author

Arcank commented Nov 30, 2016

Is CocoaPods able to run such command when installing dependencies? That would be awesome from a user point of view to streamline the installation.

@tirodkar
Copy link
Collaborator

tirodkar commented Dec 3, 2016

Since we provide a precompiled framework, our CocoaPods flow doesn't require the dependencies to be present. CocoaPods does provide a post_install hook that you can use to run any commands / scripts.

A footnote- adding a submodule would be trivial, except for OCHamcrest, where we download a zipped up release and then perform some cleanups before integrating it, such as cleaning the iOS-suffix they have (hamcrest/OCHamcrest#74). So at the end of the installation, you will still have to run the setup-earlgrey.sh script, which seems like a duplication of efforts. Since this bug is only for OCMock and fishhook though, that can be done.

@khandpur
Copy link
Collaborator

any updates on this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants