You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Currently, one needs to run (directly or indirectly) the script setup-earlgrey.sh to download them.
Why can't it be achieved via submodules? It would make setup easier.
The text was updated successfully, but these errors were encountered:
That's a good point. We could actually add submodules and remove those sections entirely from the setup file.
However, one reason we do it is because on building EarlGrey, we download these dependencies if they're not already present. We could however add git submodule update --recursive to the setup step and this would automate this as well.
Since we provide a precompiled framework, our CocoaPods flow doesn't require the dependencies to be present. CocoaPods does provide a post_install hook that you can use to run any commands / scripts.
A footnote- adding a submodule would be trivial, except for OCHamcrest, where we download a zipped up release and then perform some cleanups before integrating it, such as cleaning the iOS-suffix they have (hamcrest/OCHamcrest#74). So at the end of the installation, you will still have to run the setup-earlgrey.sh script, which seems like a duplication of efforts. Since this bug is only for OCMock and fishhook though, that can be done.
Currently, one needs to run (directly or indirectly) the script setup-earlgrey.sh to download them.
Why can't it be achieved via submodules? It would make setup easier.
The text was updated successfully, but these errors were encountered: