Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Typo in GroundingMetadata Types: groundingChuncks and groundingSupport Incorrect Naming #317

Open
ashphy opened this issue Dec 31, 2024 · 0 comments
Assignees
Labels
component:js sdk Issue/PR related to JavaScript SDK status:triaged Issue/PR triaged to the corresponding sub-team type:bug Something isn't working

Comments

@ashphy
Copy link

ashphy commented Dec 31, 2024

Description of the bug:

The types for groundings contain typos

Refer to the REST API documentation,

  • groundingChuncks -> groundingChunks
  • groundingSupport -> groundingSupports

Actual vs expected behavior:

Actual

export declare interface GroundingMetadata {
	/**
	 * Google search entry for the following-up web searches.
	 */
	searchEntryPoint?: SearchEntryPoint;
	/**
	 * List of supporting references retrieved from specified grounding source.
	 */
	groundingChuncks?: GroundingChunk[];
	/**
	 * List of grounding support.
	 */
	groundingSupport?: GroundingSupport[];
	/**
	 * Metadata related to retrieval in the grounding flow.
	 */
	retrievalMetadata?: RetrievalMetadata;
	/**
	 * * Web search queries for the following-up web search.
	 */
	webSearchQueries: string[];
}

Expected

export declare interface GroundingMetadata {
	/**
	 * Google search entry for the following-up web searches.
	 */
	searchEntryPoint?: SearchEntryPoint;
	/**
	 * List of supporting references retrieved from specified grounding source.
	 */
	groundingChunks?: GroundingChunk[];
	/**
	 * List of grounding support.
	 */
	groundingSupports?: GroundingSupport[];
	/**
	 * Metadata related to retrieval in the grounding flow.
	 */
	retrievalMetadata?: RetrievalMetadata;
	/**
	 * * Web search queries for the following-up web search.
	 */
	webSearchQueries: string[];
}

Any other information you'd like to share?

No response

@Gunand3043 Gunand3043 added type:bug Something isn't working status:triaged Issue/PR triaged to the corresponding sub-team component:js sdk Issue/PR related to JavaScript SDK labels Jan 6, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:js sdk Issue/PR related to JavaScript SDK status:triaged Issue/PR triaged to the corresponding sub-team type:bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants