Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conflict Resolved: Add .env file to suspicious files list #266 #269 Merged #277

Open
zfLQ2qx2 opened this issue Jan 30, 2025 · 0 comments
Open

Comments

@zfLQ2qx2
Copy link

zfLQ2qx2 commented Jan 30, 2025

@tomoyamachi What is the justification for this change? All of my Next.js developers are saying that the usage of .env is a very common practice and they are annoyed that dockle is flagging this.

Is this another issue like the x509 public keys where we really need to be doing some sort of inspection rather then just flagging the existence of a file?

Or maybe I could also challenge you, why are you flagging just .env and not .env.* which are also very common in nextjs environments?

.env.local – Loaded in all environments except when process.env.NODE_ENV is "test".
.env.development – Loaded only in development mode.
.env.production – Loaded only in production mode.
.env.test – Loaded only in test mode.

I think the only real valid test would be to look into the env files and look for common secret patterns.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant