Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OCT-2296: Tweak defaults of PG_POOL when max_connections increased #616

Merged
merged 10 commits into from
Jan 15, 2025

Conversation

kgarbacinski
Copy link
Contributor

Description

Definition of Done

  1. If required, the desciption of your change is added to the QA changelog
  2. Acceptance criteria are met.
  3. PR is manually tested before the merge by developer(s).
    • Happy path is manually checked.
  4. PR is manually tested by QA when their assistance is required (1).
    • Octant Areas & Test Cases are checked for impact and updated if required (2).
  5. Unit tests are added unless there is a reason to omit them.
  6. Automated tests are added when required.
  7. The code is merged.
  8. Tech documentation is added / updated, reviewed and approved (including mandatory approval by a code owner, should such exist for changed files).
    • BE: Swagger documentation is updated.
  9. When required by QA:
    • Deployed to the relevant environment.
    • Passed system tests.

(1) Developer(s) in coordination with QA decide whether it's required. For small tickets introducing small changes QA assistance is most probably not required.

(2) Octant Areas & Test Cases.

@kgarbacinski kgarbacinski requested a review from adam-gf January 7, 2025 20:15
@kgarbacinski kgarbacinski self-assigned this Jan 7, 2025
Copy link

linear bot commented Jan 7, 2025

@kgarbacinski kgarbacinski added the request-approval Request approval from the Housekeeper label Jan 7, 2025
@housekeeper-bot housekeeper-bot removed the request-approval Request approval from the Housekeeper label Jan 8, 2025
Copy link
Contributor

@housekeeper-bot housekeeper-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

E2E job #12659216355 failed 💥

@adam-gf
Copy link
Contributor

adam-gf commented Jan 9, 2025

IS this PR still relevant ?

@kgarbacinski
Copy link
Contributor Author

IS this PR still relevant ?

Yes, once this PR is merged: #621, we can proceed with this one.

@kgarbacinski kgarbacinski changed the title OCT-2296: Tweak defaults of PG_POOL for max_connections 300 OCT-2296: Tweak defaults of PG_POOL when max_connections increased Jan 12, 2025
@kgarbacinski kgarbacinski added the request-approval Request approval from the Housekeeper label Jan 13, 2025
@housekeeper-bot housekeeper-bot removed the request-approval Request approval from the Housekeeper label Jan 13, 2025
Copy link
Contributor

@housekeeper-bot housekeeper-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

E2E job #12747097073 failed 💥

@kgarbacinski kgarbacinski added the request-approval Request approval from the Housekeeper label Jan 13, 2025
@housekeeper-bot housekeeper-bot removed the request-approval Request approval from the Housekeeper label Jan 13, 2025
Copy link
Contributor

@housekeeper-bot housekeeper-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

E2E job #12750504630 failed 💥

@kgarbacinski kgarbacinski added the request-approval Request approval from the Housekeeper label Jan 14, 2025
@housekeeper-bot housekeeper-bot removed the request-approval Request approval from the Housekeeper label Jan 14, 2025
Copy link
Contributor

@housekeeper-bot housekeeper-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

E2E job #12766693123 failed 💥

@kgarbacinski kgarbacinski added the request-approval Request approval from the Housekeeper label Jan 14, 2025
@housekeeper-bot housekeeper-bot removed the request-approval Request approval from the Housekeeper label Jan 14, 2025
Copy link
Contributor

@housekeeper-bot housekeeper-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

E2E job #12771242246 passed 🎉

@kgarbacinski kgarbacinski merged commit 5d5d16d into develop Jan 15, 2025
62 of 63 checks passed
@kgarbacinski kgarbacinski deleted the kacper/chore/oct-2296-improve-backend-stability branch January 15, 2025 08:14
chris-calo pushed a commit that referenced this pull request Jan 16, 2025
)

## Description

## Definition of Done

1. [ ] If required, the desciption of your change is added to the [QA
changelog](https://www.notion.so/octantapp/Changelog-for-the-QA-d96fa3b411cf488bb1d8d9a598d88281)
2. [ ] Acceptance criteria are met.
3. [ ] PR is manually tested before the merge by developer(s).
    - [ ] Happy path is manually checked.
4. [ ] PR is manually tested by QA when their assistance is required
(1).
- [ ] Octant Areas & Test Cases are checked for impact and updated if
required (2).
5. [ ] Unit tests are added unless there is a reason to omit them.
6. [ ] Automated tests are added when required.
7. [ ] The code is merged.
8. [ ] Tech documentation is added / updated, reviewed and approved
(including mandatory approval by a code owner, should such exist for
changed files).
    - [ ] BE: Swagger documentation is updated.
9. [ ] When required by QA:
    - [ ] Deployed to the relevant environment.
    - [ ] Passed system tests.

---

(1) Developer(s) in coordination with QA decide whether it's required.
For small tickets introducing small changes QA assistance is most
probably not required.

(2) [Octant Areas & Test
Cases](https://docs.google.com/spreadsheets/d/1cRe6dxuKJV3a4ZskAwWEPvrFkQm6rEfyUCYwLTYw_Cc).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants