Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

OCT-2136: Home Video Bar E2E #601

Merged
merged 26 commits into from
Jan 19, 2025
Merged

OCT-2136: Home Video Bar E2E #601

merged 26 commits into from
Jan 19, 2025

Conversation

jmikolajczyk
Copy link
Contributor

Description

Definition of Done

  1. If required, the desciption of your change is added to the QA changelog
  2. Acceptance criteria are met.
  3. PR is manually tested before the merge by developer(s).
    • Happy path is manually checked.
  4. PR is manually tested by QA when their assistance is required (1).
    • Octant Areas & Test Cases are checked for impact and updated if required (2).
  5. Unit tests are added unless there is a reason to omit them.
  6. Automated tests are added when required.
  7. The code is merged.
  8. Tech documentation is added / updated, reviewed and approved (including mandatory approval by a code owner, should such exist for changed files).
    • BE: Swagger documentation is updated.
  9. When required by QA:
    • Deployed to the relevant environment.
    • Passed system tests.

(1) Developer(s) in coordination with QA decide whether it's required. For small tickets introducing small changes QA assistance is most probably not required.

(2) Octant Areas & Test Cases.

@jmikolajczyk jmikolajczyk requested a review from aziolek December 20, 2024 13:38
@jmikolajczyk jmikolajczyk self-assigned this Dec 20, 2024
@linear Linear
Copy link

linear bot commented Dec 20, 2024

OCT-2136 Home Video Bar E2E

@jmikolajczyk jmikolajczyk added the request-approval Request approval from the Housekeeper label Dec 20, 2024
@jmikolajczyk jmikolajczyk removed the request-approval Request approval from the Housekeeper label Dec 20, 2024
housekeeper-bot
housekeeper-bot requested changes Dec 20, 2024
View reviewed changes
Copy link
Contributor

@housekeeper-bot housekeeper-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

E2E job #12432993335 failed 💥

@jmikolajczyk jmikolajczyk added the request-approval Request approval from the Housekeeper label Dec 23, 2024
@housekeeper-bot housekeeper-bot removed the request-approval Request approval from the Housekeeper label Dec 23, 2024
housekeeper-bot
housekeeper-bot requested changes Dec 23, 2024
View reviewed changes
Copy link
Contributor

@housekeeper-bot housekeeper-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

E2E job #12464417491 failed 💥

aziolek
aziolek previously approved these changes Dec 23, 2024
View reviewed changes
@jmikolajczyk jmikolajczyk added the request-approval Request approval from the Housekeeper label Dec 24, 2024
@housekeeper-bot housekeeper-bot removed the request-approval Request approval from the Housekeeper label Dec 24, 2024
housekeeper-bot
housekeeper-bot requested changes Dec 24, 2024
View reviewed changes
Copy link
Contributor

@housekeeper-bot housekeeper-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

E2E job #12479241612 failed 💥

housekeeper-bot
housekeeper-bot requested changes Dec 27, 2024
View reviewed changes
Copy link
Contributor

@housekeeper-bot housekeeper-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

E2E job #12479241612 failed 💥

housekeeper-bot
housekeeper-bot requested changes Dec 27, 2024
View reviewed changes
Copy link
Contributor

@housekeeper-bot housekeeper-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

E2E job #12479241612 failed 💥

@jmikolajczyk jmikolajczyk added the request-approval Request approval from the Housekeeper label Dec 30, 2024
@housekeeper-bot housekeeper-bot removed the request-approval Request approval from the Housekeeper label Dec 30, 2024
housekeeper-bot
housekeeper-bot requested changes Dec 30, 2024
View reviewed changes
Copy link
Contributor

@housekeeper-bot housekeeper-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

E2E job #12544812672 failed 💥

housekeeper-bot
housekeeper-bot requested changes Dec 31, 2024
View reviewed changes
Copy link
Contributor

@housekeeper-bot housekeeper-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

E2E job #12544812672 failed 💥

@jmikolajczyk jmikolajczyk added the request-approval Request approval from the Housekeeper label Jan 10, 2025
@housekeeper-bot housekeeper-bot removed the request-approval Request approval from the Housekeeper label Jan 10, 2025
housekeeper-bot
housekeeper-bot requested changes Jan 10, 2025
View reviewed changes
Copy link
Contributor

@housekeeper-bot housekeeper-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

E2E job #12709259979 failed 💥

@jmikolajczyk jmikolajczyk added the request-approval Request approval from the Housekeeper label Jan 17, 2025
@housekeeper-bot housekeeper-bot removed the request-approval Request approval from the Housekeeper label Jan 17, 2025
housekeeper-bot
housekeeper-bot requested changes Jan 17, 2025
View reviewed changes
Copy link
Contributor

@housekeeper-bot housekeeper-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

E2E job #12835650223 failed 💥

@jmikolajczyk jmikolajczyk added the request-approval Request approval from the Housekeeper label Jan 17, 2025
@housekeeper-bot housekeeper-bot removed the request-approval Request approval from the Housekeeper label Jan 18, 2025
housekeeper-bot
housekeeper-bot requested changes Jan 18, 2025
View reviewed changes
Copy link
Contributor

@housekeeper-bot housekeeper-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

E2E job #12837924599 failed 💥

@jmikolajczyk jmikolajczyk added the request-approval Request approval from the Housekeeper label Jan 18, 2025
@housekeeper-bot housekeeper-bot removed the request-approval Request approval from the Housekeeper label Jan 18, 2025
housekeeper-bot
housekeeper-bot approved these changes Jan 18, 2025
View reviewed changes
Copy link
Contributor

@housekeeper-bot housekeeper-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

E2E job #12842725397 passed 🎉

housekeeper-bot
housekeeper-bot approved these changes Jan 18, 2025
View reviewed changes
Copy link
Contributor

@housekeeper-bot housekeeper-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

E2E job #12842725397 passed 🎉

housekeeper-bot
housekeeper-bot approved these changes Jan 18, 2025
View reviewed changes
Copy link
Contributor

@housekeeper-bot housekeeper-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

E2E job #12842725397 passed 🎉

housekeeper-bot
housekeeper-bot approved these changes Jan 19, 2025
View reviewed changes
Copy link
Contributor

@housekeeper-bot housekeeper-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

E2E job #12842725397 passed 🎉

housekeeper-bot
housekeeper-bot previously approved these changes Jan 19, 2025
View reviewed changes
Copy link
Contributor

@housekeeper-bot housekeeper-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

E2E job #12842725397 passed 🎉

@jmikolajczyk jmikolajczyk added the request-approval Request approval from the Housekeeper label Jan 19, 2025
@housekeeper-bot housekeeper-bot removed the request-approval Request approval from the Housekeeper label Jan 19, 2025
housekeeper-bot
housekeeper-bot approved these changes Jan 19, 2025
View reviewed changes
Copy link
Contributor

@housekeeper-bot housekeeper-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

E2E job #12842725397 passed 🎉

housekeeper-bot
housekeeper-bot approved these changes Jan 19, 2025
View reviewed changes
Copy link
Contributor

@housekeeper-bot housekeeper-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

E2E job #12853126073 passed 🎉

housekeeper-bot
housekeeper-bot requested changes Jan 19, 2025
View reviewed changes
Copy link
Contributor

@housekeeper-bot housekeeper-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

E2E job #12842725397 failed 💥

@jmikolajczyk jmikolajczyk added the request-approval Request approval from the Housekeeper label Jan 19, 2025
@housekeeper-bot housekeeper-bot removed the request-approval Request approval from the Housekeeper label Jan 19, 2025
housekeeper-bot
housekeeper-bot requested changes Jan 19, 2025
View reviewed changes
Copy link
Contributor

@housekeeper-bot housekeeper-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

E2E job #12842725397 failed 💥

housekeeper-bot
housekeeper-bot approved these changes Jan 19, 2025
View reviewed changes
Copy link
Contributor

@housekeeper-bot housekeeper-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

E2E job #12856017652 passed 🎉

@jmikolajczyk jmikolajczyk merged commit 2dfe820 into master Jan 19, 2025
47 checks passed
@jmikolajczyk jmikolajczyk deleted the test/oct-2136-home-video-bar-e2e branch January 19, 2025 20:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aziolek aziolek aziolek approved these changes

@housekeeper-bot housekeeper-bot housekeeper-bot approved these changes

Assignees

@jmikolajczyk jmikolajczyk

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jmikolajczyk @aziolek @housekeeper-bot