Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

OCT-2262: Align time threshold for sablier on UAT #593

Merged
merged 6 commits into from
Dec 28, 2024
Merged

OCT-2262: Align time threshold for sablier on UAT #593

merged 6 commits into from
Dec 28, 2024

Conversation

kgarbacinski
Copy link
Contributor

Description

Definition of Done

  1. If required, the desciption of your change is added to the QA changelog
  2. Acceptance criteria are met.
  3. PR is manually tested before the merge by developer(s).
    • Happy path is manually checked.
  4. PR is manually tested by QA when their assistance is required (1).
    • Octant Areas & Test Cases are checked for impact and updated if required (2).
  5. Unit tests are added unless there is a reason to omit them.
  6. Automated tests are added when required.
  7. The code is merged.
  8. Tech documentation is added / updated, reviewed and approved (including mandatory approval by a code owner, should such exist for changed files).
    • BE: Swagger documentation is updated.
  9. When required by QA:
    • Deployed to the relevant environment.
    • Passed system tests.

(1) Developer(s) in coordination with QA decide whether it's required. For small tickets introducing small changes QA assistance is most probably not required.

(2) Octant Areas & Test Cases.

@kgarbacinski kgarbacinski requested a review from adam-gf December 17, 2024 08:39
@kgarbacinski kgarbacinski self-assigned this Dec 17, 2024
@linear Linear
Copy link

linear bot commented Dec 17, 2024

OCT-2262 Align unlock time threshold for Sablier & contracts

adam-gf
adam-gf reviewed Dec 17, 2024
View reviewed changes
backend/app/settings.py Outdated Show resolved Hide resolved
adam-gf
adam-gf previously approved these changes Dec 17, 2024
View reviewed changes
@kgarbacinski kgarbacinski added the request-approval Request approval from the Housekeeper label Dec 17, 2024
@housekeeper-bot housekeeper-bot removed the request-approval Request approval from the Housekeeper label Dec 17, 2024
housekeeper-bot
housekeeper-bot requested changes Dec 17, 2024
View reviewed changes
Copy link
Contributor

@housekeeper-bot housekeeper-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

E2E job #12371912095 failed 💥

@kgarbacinski kgarbacinski added the request-approval Request approval from the Housekeeper label Dec 17, 2024
@housekeeper-bot housekeeper-bot removed the request-approval Request approval from the Housekeeper label Dec 17, 2024
housekeeper-bot
housekeeper-bot requested changes Dec 17, 2024
View reviewed changes
Copy link
Contributor

@housekeeper-bot housekeeper-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

E2E job #12373750716 failed 💥

@kgarbacinski kgarbacinski added the request-approval Request approval from the Housekeeper label Dec 19, 2024
@housekeeper-bot housekeeper-bot removed the request-approval Request approval from the Housekeeper label Dec 19, 2024
housekeeper-bot
housekeeper-bot requested changes Dec 19, 2024
View reviewed changes
Copy link
Contributor

@housekeeper-bot housekeeper-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

E2E job #12409230766 failed 💥

@kgarbacinski kgarbacinski added the request-approval Request approval from the Housekeeper label Dec 19, 2024
@housekeeper-bot housekeeper-bot removed the request-approval Request approval from the Housekeeper label Dec 19, 2024
housekeeper-bot
housekeeper-bot requested changes Dec 19, 2024
View reviewed changes
Copy link
Contributor

@housekeeper-bot housekeeper-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

E2E job #12411064865 failed 💥

@kgarbacinski kgarbacinski added the request-approval Request approval from the Housekeeper label Dec 20, 2024
@housekeeper-bot housekeeper-bot removed the request-approval Request approval from the Housekeeper label Dec 20, 2024
housekeeper-bot
housekeeper-bot requested changes Dec 20, 2024
View reviewed changes
Copy link
Contributor

@housekeeper-bot housekeeper-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

E2E job #12430704410 failed 💥

housekeeper-bot
housekeeper-bot requested changes Dec 20, 2024
View reviewed changes
Copy link
Contributor

@housekeeper-bot housekeeper-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

E2E job #12430704410 failed 💥

housekeeper-bot
housekeeper-bot requested changes Dec 20, 2024
View reviewed changes
Copy link
Contributor

@housekeeper-bot housekeeper-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

E2E job #12430704410 failed 💥

@kgarbacinski kgarbacinski force-pushed the kacper/chore/oct-2262-align-time-threshold-for-sablier branch from 567b775 to fb463a9 Compare December 20, 2024 13:03
@kgarbacinski kgarbacinski added the request-approval Request approval from the Housekeeper label Dec 20, 2024
@housekeeper-bot housekeeper-bot removed the request-approval Request approval from the Housekeeper label Dec 20, 2024
housekeeper-bot
housekeeper-bot requested changes Dec 20, 2024
View reviewed changes
Copy link
Contributor

@housekeeper-bot housekeeper-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

E2E job #12432683594 failed 💥

@kgarbacinski kgarbacinski force-pushed the kacper/chore/oct-2262-align-time-threshold-for-sablier branch from 36d9d35 to fb463a9 Compare December 23, 2024 07:04
@kgarbacinski kgarbacinski added the request-approval Request approval from the Housekeeper label Dec 26, 2024
@housekeeper-bot housekeeper-bot removed the request-approval Request approval from the Housekeeper label Dec 26, 2024
housekeeper-bot
housekeeper-bot requested changes Dec 26, 2024
View reviewed changes
Copy link
Contributor

@housekeeper-bot housekeeper-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

E2E job #12506821954 failed 💥

@kgarbacinski kgarbacinski added the request-approval Request approval from the Housekeeper label Dec 26, 2024
@housekeeper-bot housekeeper-bot removed the request-approval Request approval from the Housekeeper label Dec 26, 2024
housekeeper-bot
housekeeper-bot requested changes Dec 26, 2024
View reviewed changes
Copy link
Contributor

@housekeeper-bot housekeeper-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

E2E job #12507258071 failed 💥

@kgarbacinski kgarbacinski force-pushed the kacper/chore/oct-2262-align-time-threshold-for-sablier branch from b507464 to b405dbf Compare December 27, 2024 08:40
@kgarbacinski kgarbacinski added the request-approval Request approval from the Housekeeper label Dec 27, 2024
@housekeeper-bot housekeeper-bot removed the request-approval Request approval from the Housekeeper label Dec 27, 2024
housekeeper-bot
housekeeper-bot requested changes Dec 27, 2024
View reviewed changes
Copy link
Contributor

@housekeeper-bot housekeeper-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

E2E job #12514247722 failed 💥

housekeeper-bot
housekeeper-bot approved these changes Dec 27, 2024
View reviewed changes
Copy link
Contributor

@housekeeper-bot housekeeper-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

E2E job #12514247722 passed 🎉

@kgarbacinski kgarbacinski merged commit d6a67b3 into develop Dec 28, 2024
47 checks passed
@kgarbacinski kgarbacinski deleted the kacper/chore/oct-2262-align-time-threshold-for-sablier branch December 28, 2024 12:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@housekeeper-bot housekeeper-bot housekeeper-bot approved these changes

@adam-gf adam-gf adam-gf approved these changes

Assignees

@kgarbacinski kgarbacinski

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kgarbacinski @housekeeper-bot @adam-gf