Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

OCT-2125: Metrics E2E #570

Merged
merged 10 commits into from
Dec 5, 2024
Merged

OCT-2125: Metrics E2E #570

merged 10 commits into from
Dec 5, 2024

Conversation

jmikolajczyk
Copy link
Contributor

@jmikolajczyk jmikolajczyk commented Nov 28, 2024 •
edited
Loading

Description

Check after PR-567

Definition of Done

  1. If required, the desciption of your change is added to the QA changelog
  2. Acceptance criteria are met.
  3. PR is manually tested before the merge by developer(s).
    • Happy path is manually checked.
  4. PR is manually tested by QA when their assistance is required (1).
    • Octant Areas & Test Cases are checked for impact and updated if required (2).
  5. Unit tests are added unless there is a reason to omit them.
  6. Automated tests are added when required.
  7. The code is merged.
  8. Tech documentation is added / updated, reviewed and approved (including mandatory approval by a code owner, should such exist for changed files).
    • BE: Swagger documentation is updated.
  9. When required by QA:
    • Deployed to the relevant environment.
    • Passed system tests.

(1) Developer(s) in coordination with QA decide whether it's required. For small tickets introducing small changes QA assistance is most probably not required.

(2) Octant Areas & Test Cases.

@jmikolajczyk jmikolajczyk self-assigned this Nov 28, 2024
@linear Linear
Copy link

linear bot commented Nov 28, 2024

OCT-2125 Metrics E2E

@jmikolajczyk jmikolajczyk added the request-approval Request approval from the Housekeeper label Nov 28, 2024
@housekeeper-bot housekeeper-bot removed the request-approval Request approval from the Housekeeper label Nov 28, 2024
housekeeper-bot
housekeeper-bot requested changes Nov 28, 2024
View reviewed changes
Copy link
Contributor

@housekeeper-bot housekeeper-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

E2E job #12075006239 failed 💥

@jmikolajczyk jmikolajczyk added the request-approval Request approval from the Housekeeper label Nov 29, 2024
@housekeeper-bot housekeeper-bot removed the request-approval Request approval from the Housekeeper label Nov 29, 2024
housekeeper-bot
housekeeper-bot previously approved these changes Nov 29, 2024
View reviewed changes
Copy link
Contributor

@housekeeper-bot housekeeper-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

E2E job #12083420215 passed 🎉

@jmikolajczyk jmikolajczyk dismissed housekeeper-bot’s stale review November 29, 2024 12:05

The merge-base changed after approval.

@jmikolajczyk
Copy link
Contributor Author

/deploy

@jmikolajczyk jmikolajczyk added the request-approval Request approval from the Housekeeper label Dec 4, 2024
@housekeeper-bot housekeeper-bot removed the request-approval Request approval from the Housekeeper label Dec 4, 2024
housekeeper-bot
housekeeper-bot requested changes Dec 4, 2024
View reviewed changes
Copy link
Contributor

@housekeeper-bot housekeeper-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

E2E job #12165854178 failed 💥

@jmikolajczyk jmikolajczyk added the request-approval Request approval from the Housekeeper label Dec 4, 2024
@housekeeper-bot housekeeper-bot removed the request-approval Request approval from the Housekeeper label Dec 4, 2024
housekeeper-bot
housekeeper-bot previously approved these changes Dec 4, 2024
View reviewed changes
Copy link
Contributor

@housekeeper-bot housekeeper-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

E2E job #12167264272 passed 🎉

aziolek
aziolek reviewed Dec 4, 2024
View reviewed changes
client/cypress/e2e/_13metrics.cy.ts Outdated Show resolved Hide resolved
client/cypress/e2e/_13metrics.cy.ts Outdated Show resolved Hide resolved
client/cypress/e2e/_13metrics.cy.ts Outdated Show resolved Hide resolved
client/cypress/e2e/_13metrics.cy.ts Outdated Show resolved Hide resolved
@jmikolajczyk jmikolajczyk added the request-approval Request approval from the Housekeeper label Dec 5, 2024
@housekeeper-bot housekeeper-bot removed the request-approval Request approval from the Housekeeper label Dec 5, 2024
housekeeper-bot
housekeeper-bot requested changes Dec 5, 2024
View reviewed changes
Copy link
Contributor

@housekeeper-bot housekeeper-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

E2E job #12176903776 failed 💥

@jmikolajczyk jmikolajczyk added request-approval Request approval from the Housekeeper and removed request-approval Request approval from the Housekeeper labels Dec 5, 2024
housekeeper-bot
housekeeper-bot requested changes Dec 5, 2024
View reviewed changes
Copy link
Contributor

@housekeeper-bot housekeeper-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

E2E job #12178928038 failed 💥

@jmikolajczyk jmikolajczyk added the request-approval Request approval from the Housekeeper label Dec 5, 2024
@housekeeper-bot housekeeper-bot removed the request-approval Request approval from the Housekeeper label Dec 5, 2024
housekeeper-bot
housekeeper-bot requested changes Dec 5, 2024
View reviewed changes
Copy link
Contributor

@housekeeper-bot housekeeper-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

E2E job #12179569530 failed 💥

@jmikolajczyk jmikolajczyk added the request-approval Request approval from the Housekeeper label Dec 5, 2024
@housekeeper-bot housekeeper-bot removed the request-approval Request approval from the Housekeeper label Dec 5, 2024
housekeeper-bot
housekeeper-bot requested changes Dec 5, 2024
View reviewed changes
Copy link
Contributor

@housekeeper-bot housekeeper-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

E2E job #12179988621 failed 💥

@jmikolajczyk jmikolajczyk added the request-approval Request approval from the Housekeeper label Dec 5, 2024
@housekeeper-bot housekeeper-bot removed the request-approval Request approval from the Housekeeper label Dec 5, 2024
housekeeper-bot
housekeeper-bot requested changes Dec 5, 2024
View reviewed changes
Copy link
Contributor

@housekeeper-bot housekeeper-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

E2E job #12182351885 failed 💥

@jmikolajczyk jmikolajczyk added the request-approval Request approval from the Housekeeper label Dec 5, 2024
@housekeeper-bot housekeeper-bot removed the request-approval Request approval from the Housekeeper label Dec 5, 2024
housekeeper-bot
housekeeper-bot approved these changes Dec 5, 2024
View reviewed changes
Copy link
Contributor

@housekeeper-bot housekeeper-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

E2E job #12185504312 passed 🎉

@jmikolajczyk jmikolajczyk merged commit 986243a into master Dec 5, 2024
47 checks passed
@jmikolajczyk jmikolajczyk deleted the test/oct-2125-metrics-e2e branch December 5, 2024 20:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@housekeeper-bot housekeeper-bot housekeeper-bot approved these changes

@aziolek aziolek aziolek approved these changes

Assignees

@jmikolajczyk jmikolajczyk

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jmikolajczyk @aziolek @housekeeper-bot