Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

OCT-2193 Implement language selector: app #561

Merged
merged 33 commits into from
Jan 8, 2025
Merged

OCT-2193 Implement language selector: app #561

merged 33 commits into from
Jan 8, 2025

Conversation

aziolek
Copy link
Member

@aziolek aziolek commented Nov 21, 2024

Description

Definition of Done

  1. If required, the desciption of your change is added to the QA changelog
  2. Acceptance criteria are met.
  3. PR is manually tested before the merge by developer(s).
    • Happy path is manually checked.
  4. PR is manually tested by QA when their assistance is required (1).
    • Octant Areas & Test Cases are checked for impact and updated if required (2).
  5. Unit tests are added unless there is a reason to omit them.
  6. Automated tests are added when required.
  7. The code is merged.
  8. Tech documentation is added / updated, reviewed and approved (including mandatory approval by a code owner, should such exist for changed files).
    • BE: Swagger documentation is updated.
  9. When required by QA:
    • Deployed to the relevant environment.
    • Passed system tests.

(1) Developer(s) in coordination with QA decide whether it's required. For small tickets introducing small changes QA assistance is most probably not required.

(2) Octant Areas & Test Cases.

@aziolek aziolek self-assigned this Nov 21, 2024
@linear Linear
Copy link

linear bot commented Nov 21, 2024

OCT-2193 Implement language selector: app

@aziolek aziolek requested a review from jmikolajczyk December 2, 2024 08:57
jmikolajczyk
jmikolajczyk previously approved these changes Dec 5, 2024
View reviewed changes
@aziolek aziolek added the request-approval Request approval from the Housekeeper label Dec 5, 2024
@housekeeper-bot housekeeper-bot removed the request-approval Request approval from the Housekeeper label Dec 5, 2024
housekeeper-bot
housekeeper-bot requested changes Dec 5, 2024
View reviewed changes
Copy link
Contributor

@housekeeper-bot housekeeper-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

E2E job #12177953002 failed 💥

housekeeper-bot
housekeeper-bot requested changes Dec 5, 2024
View reviewed changes
Copy link
Contributor

@housekeeper-bot housekeeper-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

E2E job #12177953002 failed 💥

@housekeeper-bot housekeeper-bot temporarily deployed to master December 13, 2024 14:10 Destroyed
@housekeeper-bot housekeeper-bot temporarily deployed to master December 16, 2024 12:11 Destroyed
@housekeeper-bot housekeeper-bot temporarily deployed to master December 20, 2024 12:14 Destroyed
@aziolek aziolek added the request-approval Request approval from the Housekeeper label Jan 3, 2025
@housekeeper-bot housekeeper-bot removed the request-approval Request approval from the Housekeeper label Jan 3, 2025
housekeeper-bot
housekeeper-bot requested changes Jan 3, 2025
View reviewed changes
Copy link
Contributor

@housekeeper-bot housekeeper-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

E2E job #12604887738 failed 💥

@aziolek aziolek added the request-approval Request approval from the Housekeeper label Jan 3, 2025
@housekeeper-bot housekeeper-bot removed the request-approval Request approval from the Housekeeper label Jan 3, 2025
housekeeper-bot
housekeeper-bot requested changes Jan 3, 2025
View reviewed changes
Copy link
Contributor

@housekeeper-bot housekeeper-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

E2E job #12605021239 failed 💥

@aziolek aziolek marked this pull request as ready for review January 7, 2025 09:53
@aziolek aziolek requested a review from jmikolajczyk January 7, 2025 09:53
@aziolek aziolek added the request-approval Request approval from the Housekeeper label Jan 7, 2025
jmikolajczyk
jmikolajczyk requested changes Jan 7, 2025
View reviewed changes
client/src/i18n.ts Outdated Show resolved Hide resolved
@housekeeper-bot housekeeper-bot removed the request-approval Request approval from the Housekeeper label Jan 7, 2025
housekeeper-bot
housekeeper-bot requested changes Jan 7, 2025
View reviewed changes
Copy link
Contributor

@housekeeper-bot housekeeper-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

E2E job #12649272196 failed 💥

@aziolek aziolek requested a review from jmikolajczyk January 7, 2025 15:04
@aziolek aziolek added the request-approval Request approval from the Housekeeper label Jan 7, 2025
@housekeeper-bot housekeeper-bot removed the request-approval Request approval from the Housekeeper label Jan 8, 2025
housekeeper-bot
housekeeper-bot requested changes Jan 8, 2025
View reviewed changes
Copy link
Contributor

@housekeeper-bot housekeeper-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

E2E job #12660097930 failed 💥

jmikolajczyk
jmikolajczyk previously approved these changes Jan 8, 2025
View reviewed changes
@aziolek aziolek requested a review from jmikolajczyk January 8, 2025 10:10
@aziolek aziolek merged commit 5e60fd8 into master Jan 8, 2025
31 checks passed
@aziolek aziolek deleted the feature/oct-2193-language-selector-app branch January 8, 2025 10:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@housekeeper-bot housekeeper-bot housekeeper-bot requested changes

@jmikolajczyk jmikolajczyk jmikolajczyk approved these changes

Assignees

@aziolek aziolek

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@aziolek @jmikolajczyk @housekeeper-bot