Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

OCT-1284 Create an IPFS implementation with client failover #26

Merged
merged 6 commits into from
Feb 28, 2024
Merged

OCT-1284 Create an IPFS implementation with client failover #26

merged 6 commits into from
Feb 28, 2024

Conversation

aziolek
Copy link
Member

@aziolek aziolek commented Feb 24, 2024

No description provided.

@aziolek aziolek self-assigned this Feb 24, 2024
@aziolek aziolek marked this pull request as ready for review February 27, 2024 10:14
@aziolek
Copy link
Member Author

aziolek commented Feb 27, 2024 •
edited
Loading

@jmikolajczyk: to test it, please set the local environmental variable:

VITE_IPFS_GATEWAYS=https://turquoise-accused-gayal-88.mypinata.cloud/ipfs/,https://octant.infura-ipfs.io/ipfs/

@aziolek aziolek requested a review from jmikolajczyk February 27, 2024 10:14
aziolek
aziolek commented Feb 27, 2024
View reviewed changes
Copy link
Member Author

@aziolek aziolek left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • Before the production release: add a new environmental variable:
VITE_IPFS_GATEWAYS=https://turquoise-accused-gayal-88.mypinata.cloud/ipfs/,https://octant.infura-ipfs.io/ipfs/

jmikolajczyk
jmikolajczyk previously approved these changes Feb 27, 2024
View reviewed changes
Base automatically changed from master to develop February 27, 2024 15:29
@aziolek aziolek dismissed jmikolajczyk’s stale review February 27, 2024 15:29

The base branch was changed.

@aziolek aziolek changed the base branch from develop to master February 27, 2024 15:32
@mike-code mike-code changed the base branch from master to develop February 27, 2024 15:32
@mike-code mike-code changed the base branch from develop to master February 27, 2024 15:37
mike-code
mike-code previously approved these changes Feb 27, 2024
View reviewed changes
Copy link
Contributor

@mike-code mike-code left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

approving per automatic PR destination branch change

mike-code
mike-code previously approved these changes Feb 27, 2024
View reviewed changes
Copy link
Contributor

@mike-code mike-code left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

re-approving after updating argo app

@mike-code mike-code mentioned this pull request Feb 27, 2024
Closed
@aziolek aziolek merged commit 360c936 into master Feb 28, 2024
36 checks passed
@aziolek aziolek deleted the feature/oct-1284-ipfs-failover branch February 28, 2024 11:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jmikolajczyk jmikolajczyk jmikolajczyk approved these changes

@mike-code mike-code Awaiting requested review from mike-code

Assignees

@aziolek aziolek

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@aziolek @mike-code @jmikolajczyk