Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OCT-1396: Implement an onscreen route back to onboarding if users accidentally close it #164

Merged
merged 34 commits into from
May 8, 2024

Conversation

jmikolajczyk
Copy link
Contributor

@jmikolajczyk jmikolajczyk commented Apr 18, 2024

Description

Definition of Done

  1. Acceptance criteria are met.
  2. PR is manually tested before the merge by developer(s).
    • Happy path is manually checked.
  3. PR is manually tested by QA when their assistance is required (1).
    • Octant Areas & Test Cases are checked for impact and updated if required (2).
  4. Unit tests are added unless there is a reason to omit them.
  5. Automated tests are added when required.
  6. The code is merged.
  7. Tech documentation is added / updated, reviewed and approved (including mandatory approval by a code owner, should such exist for changed files).
    • BE: Swagger documentation is updated.
  8. When required by QA:
    • Deployed to the relevant environment.
    • Passed system tests.

(1) Developer(s) in coordination with QA decide whether it's required. For small tickets introducing small changes QA assistance is most probably not required.

(2) Octant Areas & Test Cases.

@jmikolajczyk jmikolajczyk requested a review from aziolek April 18, 2024 09:41
@jmikolajczyk jmikolajczyk self-assigned this Apr 18, 2024
@jmikolajczyk jmikolajczyk changed the base branch from develop to master April 18, 2024 09:42
Copy link
Member

@aziolek aziolek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Starting from around ~460px OnboardingStepper shows up over the navbar. It shouldn't be under it, but still accessible and not in a way of navigation. If designs do not cover this scenario please coordinate with Matt on the best way of solving this problem.

image

@jmikolajczyk
Copy link
Contributor Author

Starting from around ~460px OnboardingStepper shows up over the navbar. It shouldn't be under it, but still accessible and not in a way of navigation. If designs do not cover this scenario please coordinate with Matt on the best way of solving this problem.

image

@aziolek done

Copy link
Member

@aziolek aziolek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

aziolek
aziolek previously approved these changes Apr 22, 2024
@jmikolajczyk
Copy link
Contributor Author

/deploy

@jmikolajczyk
Copy link
Contributor Author

/deploy

@jmikolajczyk
Copy link
Contributor Author

/deploy

client/cypress/e2e/onboardingTOSAccepted.cy.ts Outdated Show resolved Hide resolved
client/cypress/e2e/projects.cy.ts Outdated Show resolved Hide resolved
client/cypress/e2e/projects.cy.ts Outdated Show resolved Hide resolved
client/cypress/e2e/projects.cy.ts Outdated Show resolved Hide resolved
client/cypress/utils/onboarding.ts Outdated Show resolved Hide resolved
client/cypress/utils/onboarding.ts Outdated Show resolved Hide resolved
client/cypress/utils/onboarding.ts Outdated Show resolved Hide resolved
client/src/store/onboarding/store.ts Outdated Show resolved Hide resolved
@jmikolajczyk jmikolajczyk requested a review from aziolek May 8, 2024 10:55
@jmikolajczyk jmikolajczyk merged commit e0a95e5 into master May 8, 2024
40 checks passed
@jmikolajczyk jmikolajczyk deleted the feature/oct-1396-onboarding-progress branch May 8, 2024 14:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants