crypto/internal/fips140/drbg: remove global lock #71155
Labels
BugReport
Issues describing a possible bug in the Go implementation.
FixPending
Issues that have a fix which has not yet been reviewed or submitted.
NeedsFix
The path to resolution is known, but the work has not been done.
release-blocker
Milestone
There is still a global lock in the drbg package, so that crypto/rand.Read during fips mode will have significantly more contention than without. Worse, the code is inside the fips140 boundary, meaning it will take years for any change made after the release to be recertified and propagate out into actual (fips140) usage.
I believe we should change the drbg state to be per-P, before the release. This only affects the fips140 code path, not ordinary programs running in the default (non-fips140) mode, so it should be fairly low risk.
I will look into doing this.
/cc @FiloSottile
The text was updated successfully, but these errors were encountered: