-
-
Notifications
You must be signed in to change notification settings - Fork 634
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support experiment enablement in Taskfile schema #1978
Comments
(Was just about to reply in #1038), but may as well have this discussion here now. This is why we have option 3 in our docs for enabling experiments. This allows you to commit the My main concern with adding them to the Taskfile schema itself is that it would (ironically) be a backwards-compatible change to remove the experiments later which we need to be able to do. Maybe a compromise could be to add support for a dedicated |
Ah, I see. I thought the Based on my experimentation, it seems like the experiment vars are loaded from If so, that's good enough for my team.
That makes sense but also maybe this kind of change should break visibly. I'd rather task exit with an error than for it to do something unexpected.
That sounds good, although I'm fine with the current |
Possibly related: #1979 |
I like the .task-experiments.yaml idea. It almost like task feature flags. separating it from the .env makes a lot of sense. |
Adding that handling remote experiment directly in the Taskfile schema could be tricky. I wonder if it would be better to have a more global YAML configuration file, like |
Description
Experiments like #1038 cause major changes to the behavior for a task. Given that the taskfile would have to be written to make use of this experiment, it is dangerous that the experiment has to be enabled using env vars for every engineer and every automation flow which runs that task. If the task were accidentally run without the experiment, it could lead to undesired behavior, like deploying remote environments with settings based on a developer's local environment.
The risk of dangerous, undesired behavior makes it practically impossible to use the experiment, so we have to continue using a workaround.
Ideally, we would be able to enable this experiment within the taskfile itself so that we have consistent behavior across our team and automation without any risk.
The text was updated successfully, but these errors were encountered: