Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

install task binary with optionalDependencies instead of postinstall hook #11

Open
sirenkovladd opened this issue Feb 13, 2024 · 4 comments · May be fixed by go-task/task#1675
Open

install task binary with optionalDependencies instead of postinstall hook #11

sirenkovladd opened this issue Feb 13, 2024 · 4 comments · May be fixed by go-task/task#1675

Comments

@sirenkovladd
Copy link

A lot of production CICD uses

npm install --ignore-scripts

Popular libraries install binary files use optionalDependencies
A few examples
https://www.npmjs.com/package/@swc/core?activeTab=code
https://www.npmjs.com/package/bun?activeTab=code
https://www.npmjs.com/package/@biomejs/biome?activeTab=code
https://www.npmjs.com/package/@napi-rs/snappy?activeTab=code
@sirenkovladd
Copy link
Author

will also fix #6

@sirenkovladd
Copy link
Author

Also, by default, bun install does not allow calling hooks

@andreynering
Copy link
Member

Hi @sirenkovladd,

Are you willing to open a pull request? Or at least to give more guidance here...

I'm a bit confused by the title, because the projects you linked above still have a postinstall script, so I'm not sure what you mean by "instead of postinstall hook".

@sirenkovladd
Copy link
Author

Sorry for the confusion, I think I can send a PR

@sirenkovladd sirenkovladd linked a pull request May 29, 2024 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

change install from npm scripts postinstall to optionalDependencies sirenkovladd/task
2 participants
@andreynering @sirenkovladd