Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Continuous benchmark #285

Open
EwenQuim opened this issue Dec 18, 2024 · 12 comments
Open

Continuous benchmark #285

EwenQuim opened this issue Dec 18, 2024 · 12 comments
Assignees
Labels
good first issue Good for newcomers OD Boost Issues for the OnlyDust event performance Make Fuego faster ⚡️
Milestone

Comments

@EwenQuim
Copy link
Member

EwenQuim commented Dec 18, 2024

Is your feature request related to a problem? Please describe.

To avoid performance regressions.

Describe the solution you'd like

Something like this: https://gofiber.github.io/fiber/benchmarks/

Using https://github.com/benchmark-action/github-action-benchmark

@EwenQuim EwenQuim added the good first issue Good for newcomers label Dec 18, 2024
@Jeremie-Chauvel
Copy link
Contributor

Jeremie-Chauvel commented Dec 20, 2024

Hey!
Might be interested in looking into it over holidays if nobody is working on it. Will keep you posted!

@EwenQuim
Copy link
Member Author

Nice!

I spoke with Adrien Cacciaguerra, he was interested, but Codspeed does not support Go yet...

@Jeremie-Chauvel
Copy link
Contributor

Jeremie-Chauvel commented Dec 20, 2024

It was ofc my idea to look into codspeed as plan A😁

@EwenQuim EwenQuim added the performance Make Fuego faster ⚡️ label Dec 21, 2024
@ekumamatthew
Copy link
Contributor

Could I be assigned to this?

@EwenQuim
Copy link
Member Author

I thought @Jeremie-Chauvel wanted to work on it. Ask him!

But you already have 2 first good issues to work on :)

@Jeremie-Chauvel
Copy link
Contributor

Hey @ekumamatthew, you can start, I will try to add a codspeed integration but I need to add go support to codspeed first. Having some benchmarks to upgrade to codspeed ones will help me anyway. Worst case scenario, I don't do the code speed integration and you still have benchmarks for Fuego.

TLDR: go for it

@EwenQuim
Copy link
Member Author

Using https://github.com/benchmark-action/github-action-benchmark or native go benchmark with benchstat can be a good idea. Way easier than implementing Go support to Codspeed...

@aidenwong812
Copy link

I'd love to work on this!

@EwenQuim
Copy link
Member Author

As @ekumamatthew is already working on other issues, I suggest that you can work on this one if you'd like!

@aidenwong812
Copy link

Thanks, @EwenQuim. Is there any contribution guideline that I should follow?

@EwenQuim
Copy link
Member Author

Maybe try to update/reuse the Makefile commands.

But here it's a special issue because it's CI, so no guidelines!

@aidenwong812
Copy link

Understand. Thanks.

@EwenQuim EwenQuim added the OD Boost Issues for the OnlyDust event label Jan 20, 2025
@EwenQuim EwenQuim added this to the v0.19 milestone Jan 21, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers OD Boost Issues for the OnlyDust event performance Make Fuego faster ⚡️
Projects
None yet
Development

No branches or pull requests

4 participants