-
-
Notifications
You must be signed in to change notification settings - Fork 66
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Continuous benchmark #285
Comments
Hey! |
Nice! I spoke with Adrien Cacciaguerra, he was interested, but Codspeed does not support Go yet... |
It was ofc my idea to look into codspeed as plan A😁 |
Could I be assigned to this? |
I thought @Jeremie-Chauvel wanted to work on it. Ask him! But you already have 2 first good issues to work on :) |
Hey @ekumamatthew, you can start, I will try to add a codspeed integration but I need to add go support to codspeed first. Having some benchmarks to upgrade to codspeed ones will help me anyway. Worst case scenario, I don't do the code speed integration and you still have benchmarks for Fuego. TLDR: go for it |
Using https://github.com/benchmark-action/github-action-benchmark or native go benchmark with benchstat can be a good idea. Way easier than implementing Go support to Codspeed... |
I'd love to work on this! |
As @ekumamatthew is already working on other issues, I suggest that you can work on this one if you'd like! |
Thanks, @EwenQuim. Is there any contribution guideline that I should follow? |
Maybe try to update/reuse the Makefile commands. But here it's a special issue because it's CI, so no guidelines! |
Understand. Thanks. |
Is your feature request related to a problem? Please describe.
To avoid performance regressions.
Describe the solution you'd like
Something like this: https://gofiber.github.io/fiber/benchmarks/
Using https://github.com/benchmark-action/github-action-benchmark
The text was updated successfully, but these errors were encountered: