Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove hardcoded Accept header #266

Open
EwenQuim opened this issue Dec 12, 2024 · 2 comments · May be fixed by #324
Open

Remove hardcoded Accept header #266

EwenQuim opened this issue Dec 12, 2024 · 2 comments · May be fixed by #324
Assignees
@ekumamatthew
Labels
good first issue Good for newcomers maintainance / not prio Non user-critical change that improves the codebase
Milestone
v0.19

Comments

@EwenQuim
Copy link
Member

EwenQuim commented Dec 12, 2024 •
edited
Loading

In mux.go, Fuego automatically adds an Accept header that handles Content-Negociation. But it would be better if it was declared as an option for every route in server.go, during Server creation (NewServer)
@EwenQuim EwenQuim added good first issue Good for newcomers maintainance / not prio Non user-critical change that improves the codebase labels Dec 12, 2024
@ekumamatthew
Copy link
Contributor

Can I try solving this issue?

@EwenQuim
Copy link
Member Author

Yes no problem!

@EwenQuim EwenQuim mentioned this issue Dec 26, 2024
Closed
@EwenQuim EwenQuim linked a pull request Jan 9, 2025 that will close this issue
Open
@EwenQuim EwenQuim added this to the v0.19 milestone Jan 21, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ekumamatthew ekumamatthew

Labels
good first issue Good for newcomers maintainance / not prio Non user-critical change that improves the codebase
Projects
None yet
Milestone
v0.19
Development

Successfully merging a pull request may close this issue.

refactor: move accept header from mux to server options ekumamatthew/fuego
2 participants
@EwenQuim @ekumamatthew