Unable to drag folder shortcut to the Shelf

[sheffler]

In the top shelf, there is the link to my home directory. I would like to drag a few more folders there for quick access. Drag and Drop does not seem to want to accept the Drop operation.

Platform:
Linux, WindowMaker

It is possible to add destinations by editing GWorkspace.plist and adding them to "shelfdict", so there is a workaround.

[rmottola]

It works for me if I use the copy modifier as action while dragging.
However, often it is not bound correctly or setup. In my case it is the command modifier (e.g. windows/mac key).

I am not fully convinced by some code parts, I am looking a it

[sheffler]

Okay, thanks for looking at it. I'm glad it isn't fundamentally broken.

On my system, pressing the "Super" key over "File Workspace" - the cursor turns into a "?" and then when I click on the workspace browser a context-sensitive help about "File Viewer" is displayed.

My set-up is bare laptop (no VM) using a system derived from gs-desktop. My system must be configured in some way that traps the modifier.

You can close this if there is no issue.

[rmottola]

Yes, most probably some modifier gets "grabbed" and depends also on your keyboard mapping. Standard setup tries to copie with the absence of the standard Win/Mac key and use lef-right alt for that, with limites succes. If you use windowmaker that too grabs a key for dragging.

You can try to personalize this in SystemPreferences!

However, I am investigating in why one cannot just juse simple move/drag for handling that. Would be easier! Probably the issue is that once one has a folder inside the shelf, one could also drag to it as a target! I might make a branch and offer a test version, if you wish.

I would be in release too...

[rmottola]

Furthermore I noticed that dragging certain folders and clicking on them does not reopen them, but others do work. home-level folders all work, but nested ones sometims do, sometimes not! how is it for you? I must see if it is an issue in how the item is saved or afterwars the path is interpreted. or it is just a bug of the browser "walking" to a certain path.

[rmottola]

@sheffler I opened a pull request with some work, if you want to check out the corresponding branch and/or comment.

It appears to work very well for me!!

• Put items on the shelf by simple drag-n-drop without modifiers (but they are accepted and ignored). Remove as before by just getting them oout
• Accept Link/Copy/Move as in other places for e.g. Folders put in the Shelf

[rmottola]

@sheffler I fixed the issue where some shortcuts to folders or items where not working. I tracked it down to the code that would recurse to the existing open path of the browser (root FSNode) and comparing it to the target FSNode: it was using the name, which is localised (a change done many years ago!). So technically this is a very old regression bug, but affected only users with translations active. I hope it is fixed now.

Do you care to test or should I just merge ?

[mclarenlabs]

I tried it out and it worked better. Thanks :-)

[rmottola]

Change is now merged together with fixes that will improve using the shortucts as well as restoring GWorkspace state if Language was not english! long time unrelated bug, discovered while working on this.