Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Must ensure there time-slots available for withdrawal #16

Open
josojo opened this issue Jan 15, 2019 · 1 comment
Open

Must ensure there time-slots available for withdrawal #16

josojo opened this issue Jan 15, 2019 · 1 comment

Comments

@josojo
Copy link
Contributor

josojo commented Jan 15, 2019

This simply needs to be specified exactly in the specification.

We need to make sure that we have sequential processes: pricecaculations, and deposits and withdrawals. they can not happen in parallel

@bh2smith bh2smith changed the title We need to ensure that there are timeslots for withdrawals Must ensure there time-slots available for withdrawal Jan 17, 2019
@bh2smith
Copy link
Contributor

To elaborate a bit more, there are two (somewhat) contradictory paragraphs

The first stating that account states can't change during price finding.

Participants can provide state transitions that apply pending deposits and withdrawals only while the order collection process is ongoing (the current batch is not yet frozen). Since price finding and order matching is a computationally expensive task, the account state must not change while the optimization problem is ongoing, as this could potentially invalidate correct solutions (e.g. a withdraw could lead to insufficient balance for a matched trade). As soon as the matching of a closed batch is applied, pending withdrawls and deposits can again be applied to the state.

and later on,

After a certain time-frame or once the maximum number of orders per batch are collected, a batch is "frozen" and the orders participating in it are final. A new batch could immediately start collecting new orders while the previous one is being processed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants