-
Notifications
You must be signed in to change notification settings - Fork 393
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix cd gnovm; make imports
#3577
Comments
|
Maybe we can turn it into some kind of |
Fixed in #3602 We will close this issue until we encounter a similar problem in the future. |
moul
added a commit
that referenced
this issue
Feb 9, 2025
for the context, i was trying to fix these unrelated PR diffs: https://github.com/gnolang/gno/pull/3176/files#diff-adbe9861bf11ff27b97aafd5a5e8bbe30dca0474c3008cd066f7fd8863b8b3d0L1, then I noticed #3577. This PR: - reformats the generated files - updates the makefiles to ensure that `make generate` will also format the generated files - updates the CI to check for both formatted and generated files - [x] Depends on #3577 - [x] Depends on #3584 --------- Signed-off-by: moul <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
#3455 introduced a bug when we run
cd gnovm; make imports
.We need to fix the
make imports
command to ignore those intentionally invalid files or move them elsewhere so that they are excluded.Additionally, we need to ensure that the CI checks for
make imports
result in success, similar to how we handlemake fmt
.The text was updated successfully, but these errors were encountered: