ufmt doesn't display the unicode emojis correctly

[MalekLahbib]

Description

I tried to use unicode emojis with ufmt but each time I have athis character: â

here's my code:

and here's what's displayed :

I tried with other unicode emojis and had the same result.

I discussed this with @moul and he explained to me that the problem is the way ufmt.Sprintf works and challenged me to correct the function so that it works with unicode: Challenge accepted!!

PS: give me some time, I'm not that genius 😃

[MalekLahbib]

I modified ufmt.Sprintf function as @moul suggested, by converting the entry string to [ ]rune, I made some tests and it seems to work correctly now. I pushed to my fork,I have a PR waiting 1811.

[leohhhn]

Hey @MalekLahbib, have you managed to open a new PR for this since we talked on #1811?

[notJoon]

Hey @MalekLahbib, have you managed to open a new PR for this since we talked on #1811?

If you don't plan to open a PR for this issue, may I handle this if you don't mind?

[MalekLahbib]

Hey @MalekLahbib, have you managed to open a new PR for this since we talked on #1811?

If you don't plan to open a PR for this issue, may I handle this if you don't mind?

Hey @notJoon, sorry for the delay of the response, I had some issues on my PC and with git (still a newbee 😆 ), I made this PR 1889, you can take a look and tell me what you think of it.

[MalekLahbib]

this issue is supposed to be solved with this PR 1889

[leohhhn]

Hey, just a heads up - you always should wait for a PR to be merged before closing an issue. Since you've closed the issue before merging the fix, people might thing that the issue has been fixed while if fact it was not.

P.S. you can actually link PRs and issues so if you merge a PR the issue automatically gets closed :)