Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wrong OTL ids returned #24

Open
Adafede opened this issue Feb 8, 2021 · 3 comments
Open

Wrong OTL ids returned #24

Adafede opened this issue Feb 8, 2021 · 3 comments
Labels
bug Something isn't working

Comments

@Adafede
Copy link

Adafede commented Feb 8, 2021

Hi,

I am actually comparing the Open Tree of Life IDs retrieved via GNVerify and via rotl (official Open Tree of Life API).
They give almost identical results (which is good!) but sadly in some cases, they differ.

Here is an example:

echo "Petroselinum crispum" | gnverify -s 179 -f pretty

giving

"recordId": "959097"

where when doing it via rotl (in R):

library(rotl)

name <- "Petroselinum crispum"

tnrs_match_names(
  names = name,
  do_approximate_matching = FALSE,
  include_suppressed = FALSE
)

search_string unique_name approximate_match ott_id is_synonym flags 1 petroselinum crispum Petroselinum crispum FALSE 2485 FALSE number_matches 1 1

Which indeed verifies:

https://tree.opentreeoflife.org/taxonomy/browse?name=2485

vs

https://tree.opentreeoflife.org/taxonomy/browse?name=959097

Thank you again for your wonderful work, hope those issues help!

@dimus
Copy link
Member

dimus commented Feb 8, 2021

I wonder if they made updates to OTT, but did not publish it yet. It seems they still have OTT v3.2 from 2019 for download

https://tree.opentreeoflife.org/about/taxonomy-version/ott3.2

@Adafede
Copy link
Author

Adafede commented Feb 8, 2021

When looking at both

https://tree.opentreeoflife.org/taxonomy/browse?name=2485

vs

https://tree.opentreeoflife.org/taxonomy/browse?name=959097

Couldn't it be that you have only the first part of the line being "Petroselinum crispum" in your data and that the "Neapolitanum Group" was cropped? It could maybe explain it...

I have the local ott3.2 version and they are present in this exact same way.

@dimus dimus added the bug Something isn't working label Feb 8, 2021
@dimus
Copy link
Member

dimus commented Feb 8, 2021

I see, I think it is a bug. gnverify should return as the best result https://tree.opentreeoflife.org/taxonomy/browse?name=2485, because it was parsed clearly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants