Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Be able to override the "Can post without approval" option when editing/answering #8

Open
ferrannp opened this issue Nov 29, 2015 · 2 comments

Comments

@ferrannp
Copy link

Hello and thanks for this extension! I'd explain my case and please let me know what do you think about including it as part of your extension. I'd like to have a subforum with these options:

  • For a user to create a new topic, it needs approval (Working)
  • When an user edits an own post (first one or own answer) no need for approval (Not working)
  • When an user replies to an own post (that we had to approve before) then, it doesn't need more approval (Not working)

For now, with the extension I marked these options:

  • Can edit own replies
  • Can edit first post of own topics

But still for any edit or reply it requires an approval. I think I'd make more sense to override "Can post without approval" to Yes if I have marked the mentioned options.

@gn36
Copy link
Owner

gn36 commented Nov 29, 2015

I have not changed the behavior of the approval option so far, so it should currently behave as always: Either all posts of a user will need approval on posting, or none. I guess it would make sense to be able to split that into first post and remaining posts as well.

However, the option for approval for editing a post is definitely outside the scope of this extension since that would require quite a big functional change I believe. So far, I don't think phpBB requires approval for editing posts (and that would be quite a change to include as it would require storing multiple versions of the same post). So unless that permission is implemented in the core or provided by some other extension with an appropriate hook, I don't think I will integrate that part.

I will take a look into the splitting of approval on first post and replies, though.

@ferrannp
Copy link
Author

I will take a look into the splitting of approval on first post and replies, though.

Thanks for this.

So far, I don't think phpBB requires approval for editing posts.

But right now, this it's what happens if I have a "No" in the option Can post without approval . The most annoying part is if a user starts a topic, you approve the topic, then the user edits that post... The post disappears from the board! and its waiting for approval again.

I guess if you don't see a way to change this using the extension (which I think it will be pretty useful), I will need to post in the phpBB forums.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants