Question: Versioning vs. React support?

[rxaviers]

Should we do a major bump for each React major bump? Specially testing is easier if we follow that pattern. A weakness though is that we make the webpack versions matrix a bit more complex.

The goal of this issue is to collect feedback. Please, weigh in...

Options for now:
a) Leave 0.x for React 15 compatibility, make 1.x for React 16. Pros) easier testing. Cons) crazy webpack versions matrix, or
b) Consider 0.x supports both React 15 and 16. The problem here is that we can't ensure that support in our tests.

Open to additional suggestions...

[diligiant]

I would not enter the matrix (!)
How about doing a major bump when and only when we have to write code that breaks version n-1 of the major (webpack and React) libs?
Is this too simple?

[rxaviers]

Is this too simple?

It seems simple assuming all we do don't break backwards compat, which by theory means including if-else conditions throughout the code to handle the different React versions. Code can get complex. Nevertheless, how can we systematically assert that all react versions are still working. Test can get complex too.

[diligiant]

I must have explained myself poorly as I meant specifically not handling different react/webpack versions but having the latest major working with the latest “breaking” versions of these “libraries”. And one will be able to backport to his/her (n-x) major if needed.

[alex-stripe]

Potentially should be its own issue, but trying to avoid exploding react 16 threads.

Can we get the current react 16 changes into a release? It's currently one of our only React 16 blockers. If not, is there something I can contribute to make that happen?

Thanks!

[necolas]

I think Twitter maintains an internal fork (due to issues getting patches here merged and released). Might be worth reaching out. And/or allowing Twitter/Stripe to maintain this repo and publish new versions

[rxaviers]

Hi @alex-stripe and @necolas, I acknowledge I haven't been able to maintain it as I think it deserves. Please, is there anyone from your companies who would be interested to?

[necolas]

cc @paularmstrong

[rxaviers]

@alex-stripe @paularmstrong? Ping

[alex-stripe]

I can commit to getting out a new release, if you'd like.

[rxaviers]

Sure! Feel free to ping me on Slack if you need to chat about the release process or if you have any question. Thanks

[alex-stripe]

I think the docs are pretty clear, I may wait til monday so i'm around to handle any accidents. I assume I'll need access to the npm org as well as a publisher.

[alex-stripe]

also maybe add @SlexAxton and I can do it from that account, I'm just on my work computer when I'm thinking about this at the moment.

[rxaviers]

Ok sounds good. About npm, you were included. :)

[rxaviers]

I had included that account too. You may have received emails. Otherwise please just let me know

[SlexAxton]

Ur the best @rxaviers

[rxaviers]

Our thoughts were in sync 😉

[SlexAxton]

I fixed a few things up, built, tagged, and deployed a new version. Please feel free to ping me if anyone notices any issues.