Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

@glimmer/syntax 0.94.0 is broken #1688

Closed
fisker opened this issue Jan 23, 2025 · 1 comment · Fixed by #1689
Closed

@glimmer/syntax 0.94.0 is broken #1688

fisker opened this issue Jan 23, 2025 · 1 comment · Fixed by #1689

Comments

@fisker
Copy link
Contributor

fisker commented Jan 23, 2025 

> (await import('@glimmer/syntax')).preprocess('<h1></h1>')
Uncaught TypeError: Cannot read properties of undefined (reading 'length')
    at P (<CWD>/node_modules/@glimmer/syntax/dist/prod/index.js:368:12)
    at U.matchFor (<CWD>/node_modules/@glimmer/syntax/dist/prod/index.js:436:12)
@NullVoxPopuli
Copy link
Contributor

Thanks for reporting! Will fix asap

NullVoxPopuli added a commit that referenced this issue Jan 23, 2025
@NullVoxPopuli
Try to make a test to prevent #1688 (and other prettier breakages)
0ac2e15
@NullVoxPopuli NullVoxPopuli mentioned this issue Jan 23, 2025
Merged
NullVoxPopuli added a commit that referenced this issue Jan 23, 2025
@NullVoxPopuli
Try to make a test to prevent #1688 (and other prettier breakages)
bcf1cd3
NullVoxPopuli added a commit that referenced this issue Jan 23, 2025
@NullVoxPopuli
Fix #1688
e484f96
NullVoxPopuli added a commit that referenced this issue Jan 26, 2025
@NullVoxPopuli
Prevent #1688 (and other accidental prettier breakages) (#1689)
bfd391f 
* Try to make a test to prevent #1688 (and other prettier breakages)

* Seems fine so far...

* Add node testing to CI

* delete unused file

* Remove mention of run-node-tests

* Why isn't linting working?

* As I feared, we have the build wrong

* idk man

* run pnpm repo:update:metadata

* Lints -- these are actually all correct

* Fix #1688

* Move test project into a real project, rather than tmp for easier poking around

* Set vitest conditions

* Curious

* Fix node smoke

* Remove extraneous test

* Why doesn't my local CLI env match CI

* lockfile

* different logging

* Now its working?

* Codify the requirements for running the types check

* More turbo progress

* omg it worked

* Maybe I just remove the local lint script

* Don't need that anymore

* Fix

* Updates

* fix

* last fix?
@github-actions github-actions bot mentioned this issue Jan 26, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Prevent #1688 (and other accidental prettier breakages) glimmerjs/glimmer-vm
2 participants
@fisker @NullVoxPopuli