Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PR autolinks are rendered in issues section #3956

Open
nzaytsev opened this issue Jan 20, 2025 · 0 comments · May be fixed by #3957
Open

PR autolinks are rendered in issues section #3956

nzaytsev opened this issue Jan 20, 2025 · 0 comments · May be fixed by #3957
Assignees
Labels
area-autolinks Issues or features related to autolinks

Comments

@nzaytsev
Copy link
Contributor

nzaytsev commented Jan 20, 2025

If there is a PR with id X and no issue with the same id, and we have a branch with the name containing the X substring, it will be handled as PR on the autolinks core side

The lifecycle of autolinks on the branches overview component is:

  • match keys from the text (branch name). Non-prefixed keys are always considered as issues (not PRs)
  • enrich autolinks (check if the links are available). Github automatically redirects issues to PRs if it possible
  • display autolinks as issues

We need to add some protection:

  1. pass autolink type and don't show PR autolinks near to issues
  2. lock redirect to PR for non-prefixed issue keys
@nzaytsev nzaytsev self-assigned this Jan 20, 2025
@nzaytsev nzaytsev linked a pull request Jan 20, 2025 that will close this issue
7 tasks
@eamodio eamodio added the area-autolinks Issues or features related to autolinks label Jan 22, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-autolinks Issues or features related to autolinks
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants