Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Updated 'The Picture element' section as per issue requirements #35832

Merged
merged 3 commits into from
Jan 6, 2025
Merged

Updated 'The Picture element' section as per issue requirements #35832

merged 3 commits into from
Jan 6, 2025

Conversation

a8h1km
Copy link
Contributor

@a8h1km a8h1km commented Jan 5, 2025

Why:

Closes: #35790

This change updates the "The Picture element" section to meet the issue requirements by simplifying the content and focusing on the <picture> HTML element support.

What's being changed (if available, include any code snippets, screenshots, or gifs):

  • Updated the section previously titled "Specifying the theme an image is shown to" to "The Picture element."
  • Replaced all content with the sentence: "The <picture> HTML element is supported."
  • Removed outdated references to #gh-dark-mode-only and #gh-light-mode-only fragments.

Preview of the updated content:

# The Picture element

The `<picture>` HTML element is supported.

<!-- Let us know what you are changing. Share anything that could provide the most context.
If you made changes to the `content` directory, a table will populate in a comment below with links to the preview and current production articles. -->

### Check off the following:

- [ ] A subject matter expert (SME) has reviewed the technical accuracy of the content in this PR. In most cases, the author can be the SME. Open source contributions may require a SME review from GitHub staff.
- [x] The changes in this PR meet [the docs fundamentals that are required for all content](http://docs.github.com/en/contributing/writing-for-github-docs/about-githubs-documentation-fundamentals).
- [x] All CI checks are passing.

@welcome Welcome
Copy link

welcome bot commented Jan 5, 2025

Thanks for opening this pull request! A GitHub docs team member should be by to give feedback soon. In the meantime, please check out the contributing guidelines.

@github-actions github-actions bot added the triage Do not begin working on this issue until triaged by the team label Jan 5, 2025
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jan 5, 2025 •
edited
Loading

Automatically generated comment ℹ️

This comment is automatically generated and will be overwritten every time changes are committed to this branch.

The table contains an overview of files in the content directory that have been changed in this pull request. It's provided to make it easy to review your changes on the staging site. Please note that changes to the data directory will not show up in this table.

Content directory changes

You may find it useful to copy this table into the pull request summary. There you can edit it to share links to important articles or changes and to give a high-level overview of how the changes in your pull request support the overall goals of the pull request.

Source Preview Production What Changed
get-started/writing-on-github/getting-started-with-writing-and-formatting-on-github/basic-writing-and-formatting-syntax.md fpt
ghec
ghes@ 3.15 3.14 3.13 3.12 3.11 3.10
fpt
ghec
ghes@ 3.15 3.14 3.13 3.12 3.11 3.10

fpt: Free, Pro, Team
ghec: GitHub Enterprise Cloud
ghes: GitHub Enterprise Server

@nguyenalex836 nguyenalex836 added content This issue or pull request belongs to the Docs Content team get started Content related to "Getting Started" doc set and removed triage Do not begin working on this issue until triaged by the team labels Jan 6, 2025
@nguyenalex836
Copy link
Contributor

@a8h1km Thanks so much for opening a PR with this fix! I've made one small edit to keep our title capitalization consistent 💛 I'll update the branch and get this merged once tests are passing 🍏

@nguyenalex836 nguyenalex836 added this pull request to the merge queue Jan 6, 2025
Merged via the queue into github:main with commit 2f8656e Jan 6, 2025
45 checks passed
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jan 6, 2025

Thanks very much for contributing! Your pull request has been merged 🎉 You should see your changes appear on the site in approximately 24 hours. If you're looking for your next contribution, check out our help wanted issues ⚡

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nguyenalex836 nguyenalex836 nguyenalex836 approved these changes

Assignees
No one assigned
Labels
content This issue or pull request belongs to the Docs Content team get started Content related to "Getting Started" doc set
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Update "Specifying the theme an image is shown to" section in basic-writing-and-formatting-syntax.md
2 participants
@a8h1km @nguyenalex836