From 0947d8410e6a33e71cc92952c20c1a62211a7090 Mon Sep 17 00:00:00 2001 From: Asger F Date: Fri, 17 Jan 2025 14:20:40 +0100 Subject: [PATCH] JS: Update DifferentKindsComparisonBypassQuery.qll --- .../dataflow/DifferentKindsComparisonBypassQuery.qll | 5 +---- 1 file changed, 1 insertion(+), 4 deletions(-) diff --git a/javascript/ql/lib/semmle/javascript/security/dataflow/DifferentKindsComparisonBypassQuery.qll b/javascript/ql/lib/semmle/javascript/security/dataflow/DifferentKindsComparisonBypassQuery.qll index c51bf736d873..f8aceb95128f 100644 --- a/javascript/ql/lib/semmle/javascript/security/dataflow/DifferentKindsComparisonBypassQuery.qll +++ b/javascript/ql/lib/semmle/javascript/security/dataflow/DifferentKindsComparisonBypassQuery.qll @@ -22,10 +22,7 @@ private module DifferentKindsComparisonBypassConfig implements DataFlow::ConfigS predicate isBarrier(DataFlow::Node node) { node instanceof Sanitizer } predicate observeDiffInformedIncrementalMode() { - // TODO(diff-informed): Manually verify if config can be diff-informed. - // ql/lib/semmle/javascript/security/dataflow/DifferentKindsComparisonBypassQuery.qll:39: Flow call outside 'select' clause - // ql/lib/semmle/javascript/security/dataflow/DifferentKindsComparisonBypassQuery.qll:40: Flow call outside 'select' clause - none() + none() // Disabled since multiple related sinks are selected simultaneously } }