Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove dev-env container images from ghcr.io #66

Open
qmonnet opened this issue Jan 15, 2025 · 7 comments
Open

Remove dev-env container images from ghcr.io #66

qmonnet opened this issue Jan 15, 2025 · 7 comments
Assignees

Comments

@qmonnet
Copy link
Member

qmonnet commented Jan 15, 2025

The dev-env container images are no longer used, we should remove them to avoid any confusion.

I currently don't have enough permissions on this repo to do this myself.

@qmonnet
Copy link
Member Author

qmonnet commented Jan 15, 2025

I see that the doc-env and frr containers also have very few downloads, we might want to clean them up as well if they're not in use.

[EDIT: doc-env is used in the dataplane repo for generating the docs, we want to keep it.]

@qmonnet qmonnet self-assigned this Jan 21, 2025
@daniel-noland
Copy link
Collaborator

@qmonnet, I am not sure how or why you wouldn't have sufficient permissions on this repo. You should be admin here. Will work on that.

As to the goal, yes we for sure want to keep doc-env. I need to briefly go back over the code and make sure we don't need dev-env for the sterile build back in the dataplane repo. If not then you are correct, we can kill it.

@daniel-noland
Copy link
Collaborator

Just looked. We want to keep compile-env. All references to dev-env are gone from this repo tho. We can remove them from ghcr.io if that is helpful

@qmonnet
Copy link
Member Author

qmonnet commented Jan 27, 2025

I am not sure how or why you wouldn't have sufficient permissions on this repo. You should be admin here.

I don't think I am admin on dpdk-sys, I can't see the settings tab for this repo. I also can't see the Package settings button that I'm supposed to click to be able to remove this package.

@daniel-noland
Copy link
Collaborator

I looked into it. For some reason I was the only admin. You have explicit admin permissions now, as does the rest of the dataplane-reviewers group.

We will want to reduce that scope later on once our devops team is built out.

Either of us can remove the package at this point but I suggest that you give it a try so we can confirm the settings change worked.

@qmonnet
Copy link
Member Author

qmonnet commented Jan 29, 2025

As it turns out, I can delete any package from the repo, except for... dev-env. I don't know why, but I can't see the button “Package settings” (docs) for this one (I do see it for the other three packages). I noted it's also the only package in the repo tagged as Internal, but I'm not sure this has an impact.

Daniel do you see the settings for the dev-env package?

@qmonnet
Copy link
Member Author

qmonnet commented Feb 5, 2025

@daniel-noland Can we have a quick look into this at some point, to clean up this package and close the issue, please?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants