Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Tests #29

Closed
gitfrosh opened this issue Mar 3, 2021 · 5 comments
Closed

Add Tests #29

gitfrosh opened this issue Mar 3, 2021 · 5 comments
Assignees
@MateuszKikmunter
Labels
enhancement New feature or request hacktoberfest

Comments

@gitfrosh
Copy link
Owner

gitfrosh commented Mar 3, 2021 •
edited
Loading

This Repo is entirely non-tested. 😭
Pull requests including

  • a CRA / jest / react-testing-library setup and some unit tests for the frontend
  • a test setup for the backend

are very welcome.
@gitfrosh gitfrosh changed the title Add Test Add Tests Mar 3, 2021
@gitfrosh gitfrosh added the enhancement New feature or request label Jun 1, 2021
@MateuszKikmunter
Copy link
Collaborator

Hey, I might look into backend tests. I already added few in my other PR and can continue working on that.

@EddieEldridge
Copy link
Contributor

Once the tests are in we should look at adding some basic CI, either with GitHub Actions/CircleCI/Travis or something similar. It would help a lot with reviewing future PRs.

@MateuszKikmunter
Copy link
Collaborator

Agree, it would be beneficial. Maybe it's worth to create another issue?

@EddieEldridge
Copy link
Contributor

Agree, it would be beneficial. Maybe it's worth to create another issue?

Yep, good idea. See #54

@MateuszKikmunter MateuszKikmunter self-assigned this May 2, 2024
@MateuszKikmunter MateuszKikmunter mentioned this issue May 9, 2024
Merged
@MateuszKikmunter
Copy link
Collaborator

Added frontend tests and now api finally should have a valuable suite of tests. (unit for now)
I'm closing this issue as with this PR we have enough tests at the moment.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@MateuszKikmunter MateuszKikmunter

Labels
enhancement New feature or request hacktoberfest
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@gitfrosh @EddieEldridge @MateuszKikmunter