Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Require Java 17 (LTS) #708

Open
TheSnoozer opened this issue Mar 4, 2024 · 9 comments
Open

Require Java 17 (LTS) #708

TheSnoozer opened this issue Mar 4, 2024 · 9 comments

Comments

@TheSnoozer
Copy link
Collaborator

Describe the question / problem (required)

As per https://www.oracle.com/java/technologies/java-se-support-roadmap.html
11 (LTS) Premier Support Until September 2023.

Maybe the plugin should require Java 17?

Context (optional)

No response

@TheSnoozer
Copy link
Collaborator Author

As per https://maven.apache.org/docs/history.html
maven 4.0.0-alpha-13 now requires Java 17

@TheSnoozer TheSnoozer changed the title Require 17 (LTS) Require Java 17 (LTS) Mar 20, 2024
@elharo
Copy link

elharo commented Jul 22, 2024

Please don't. We are using this with Java 8. I expect others are too.
Also note that Oracle != Java. Java 8 is fully supported by multiple vendors

@TheSnoozer
Copy link
Collaborator Author

Maven 4.X is requiring Java 17 so this (breaking)change will eventually happen, not sure when.

Certainly there is IMHO the following to consider:

Whenever it is happening needs to evaluate what the best new version would be....I guess as this is a maven plugin following maven makes sense and enforcing java 17 eventually...

@elharo
Copy link

elharo commented Jul 22, 2024

But Maven 3.9 is continuing, and I expect many projects will stick with that for compatibility reasons. Java 8 will go away eventually but not for multiple years yet.

@scrobbleme
Copy link

Please don't. We are using this with Java 8. I expect others are too. Also note that Oracle != Java. Java 8 is fully supported by multiple vendors

Is there any serious reason to still stick to Java 8 for the build prozess...? You can use a modern Java and still build for 8...

+1 for upgrading to Java 17. Escpecially with the (hopefully soon) release of Maven 4 ...

@elharo
Copy link

elharo commented Feb 6, 2025

There are incompatibilities. One I recently noticed was that jdeprscan 17 can't analyze java 8.

@scrobbleme
Copy link

There are incompatibilities. One I recently noticed was that jdeprscan 17 can't analyze java 8.

(No offense meant, I'm just curious)

Thanks for the example, but isn't this more like a "once in a lifetime" command?
If you are still using Java 8 and still need to scan for deprecations regularly... doesn't sound like the typical blocker for a Maven plugin like this ;)

@elharo
Copy link

elharo commented Feb 7, 2025

That's just the most recent thing I found. There's a lot of others, and likely others I've not yet noticed. There's very good reason for many shops and projects to stay on java 8 specifically given what Sun/Oracle did in Java 9+.

@TheSnoozer
Copy link
Collaborator Author

Ok let me explain: This ticket is here to *eventually move this plugin to Java 17. I'm well aware that there is more than "just" oracle who provides a version/variant of java, but even those other variants will stop to be supported at some point in the future. Therefore I can't comment when java 17 will be required, but at some point it will happen and should happen as some of the plugin's dependency already require a more recent java version (e.g. see git-commit-id/git-commit-id-plugin-core#172). Maybe when it's time to do this I will no longer have the time/motivation to maintain this project so maybe this update will never happen.

TDLR: I acknowledge that users still want and need this plugin to function with java 8. Eventually the plugin will be updated to java 17 - if your project still requires java 8 you can simply use an older version of the plugin...it's your choice. But eventually (maybe in 3 years or some time in the future) the plugin will drop java 8.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants