-
Notifications
You must be signed in to change notification settings - Fork 43
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Standardize library, releases and processes #69
Comments
Thank you for your investment! Indeed, this is something that will have to be implemented fairly quickly. I plan to set up an automatic build via azure-devops so that it:
Do you usually use github actions, travis or other CI-CD tools? Or are you familiar with azure-devops ? We should also add badges https://badge.fury.io I also started to setup unit tests but I did not find enough time to continue them. |
I started with https://github.com/gilsdav/ngx-translate-router/tree/add-legacy-unit-tests |
Sorry @gilsdav I left this comment as a draft on the mobile app. Sure, I used Travis and CircleCI. I never used GitHub Actions but I read about it and seems pretty simple to implement and efficient, I agree with you we can use it. I think that with a little work I can replicate the scenario that I did on some other libraries with the following features:
What do you think? |
Looks great :)
For github action it looks simple as https://github.community/t/npm-test-jasmine/17870 |
For sure, the GitHub release it's a manual process that is very simple with some tools. The same for the changelog, that is only generated in the release process.
Create several new scripts with watchers (tests for example), separate the two libraries, and the demo.
I did not check yet but I did the same operation in two other libraries and I found several differences between a library created from scratch by the last version of Angular CLI (angular.json, tsconfigs, etc...). The process it's pretty simple, just create the Angular CLI workspace, create the two libraries and the demo app and copy the actual code. Every time that I need to update some libraries or apps I follow this process to get the new features and prevent the differences. |
First version of PR pipeline: https://github.com/gilsdav/ngx-translate-router/pull/80/files#diff-e115b04ed1692a2ad3f39021f1b3ec20 |
I think that several files and processes should be added to make this library stronger and standard.
I can do some of these actions because I did it in other libraries.
The text was updated successfully, but these errors were encountered: