Most Examples are now working #7
ghiscoding
started this conversation in
General
Replies: 0 comments
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
-
@speige @joelpenov @garnerdy @dgarner-degasolutions
Hey guys, I'm not sure if you are still interested in using the lib but I had free time and started to look at what still didn't work. I'm happy to say that most Examples are now fully working (except for few examples which are: 19-Row Detail, 26-React Component,
28-29-Tree Data (Hierarchical)and that's it). Everything else works, even the i18n locale works. One of the first issue I looked into was the fact that React doesn't seem to play well with Custom Events (I did find a way to patch that and now all events are working the exact same way as all other slickgrid libs, i.e. Angular-Slickgrid and others). I also upgraded every dependencies to latest, that is React 18 even Slickgrid-Universal 2.0 (which removed jQueryUI requirement). I also added 2x new Examples 33 and 34 and made a lot of cleanups in scripts and code.Some of the examples that I am not expecting to fix are the Example 19 and 26 which are both related since they both require to dynamically render React component directly from javascript.
As for the Examples 28-29 Tree Data requires to mutate the data and I'm not sure if React is allowing that on the Props dataset.I did not yet publish a new version but expecting to release a new version, probably
1.1.0
, in the next few days.All in all, that was a good exercise to learn a bit more about how React does things (which I'm still not a fan). It also gave me a chance to find new bugs in Slickgrid-Universal, lol yeah... So anyway, once I fix all these bugs I'll push a new release. Let me know if you're still interested in the lib. Cheers
One of the things I'd like to have help with is the React Router (which I also upgraded to latest), it is still not being configured as a SPA (single page app) and it refreshes the entire page anytime we change Example. I just don't understand how to configure that and why React Hooks aren't working in Classes. Also, in order to provide a live demo by using GitHub pages, it requires to disable push state (or if you prefer, we need to use routes with the hash tag symbolI finally found how to do it by finding a boilerplate project on the internet.#
, so I need the SPA to work as work to push a live prod demo)EDIT
I managed to fix pretty much everything, except Row Detail, everything else works even Tree Data (hierarchical). The React Router as SPA is still a problem.
EDIT 2
This is it, I got everything working, I got i18n, OData, GraphQL, Tree Data, SPA router (hash router for my use case) and a Live Demo since I found how to do SPA router. I also added Cypress and got all E2E tests working, it allowed me to find and fix few more small issues. I will make an official release in the next few days after finishing up some small tasks left to do, I expect to have an official release by the weekend.
Below is the list of the Examples that are now fully working
Beta Was this translation helpful? Give feedback.
All reactions