Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Repeat visit count #15

Open
frix00 opened this issue Feb 26, 2014 · 0 comments
Open

Repeat visit count #15

frix00 opened this issue Feb 26, 2014 · 0 comments

Comments

@frix00
Copy link

frix00 commented Feb 26, 2014

Hi,

I've used this library in a recent project and it worked well. A few comments though:

  • If the setAccount function is used on every page, this is causing an issue, because the gainit() function is called everytime and it re-initialises a new visit. So the fix is either to set the account once on the first page, or to remove the gainit() and do it elsewhere.
  • Also, the logic around the utm cookie is slightly wrong. The cookie should hold a time stamp for the first visit ever, the last visit, and the start of the current visit. From what I saw, the last visit time stamp doesn't work and remains set to the first ever visit. SSome simple logic need to be added to remember in local storage the data of the last visit and pull that in on gainit()

I hope that makes sense. I'm happy to provide further evidence, as well as potential ideas for resolution.

Thanks for a great library

Greg

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants