Simple Check Feature Task xtask
#7041
Merged
+155
−21
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cwfitzgerald
force-pushed
the
cw/check-feature-deps
branch
from
1cf69ae to
f995930
Compare
ErichDonGubler
approved these changes
Jan 31, 2025
There was a problem hiding this comment.
Conditionally approving, with one potential problem to resolve and a nit.
I used Conventional Comments in this review! I hope they help with clarity and tone. 🙂
xtask/src/run_wasm.rs
Outdated
| binary_name: "wasm-bindgen", | ||
| }]; | ||
|
|
||
| if no_serve { |
There was a problem hiding this comment.
This seems wrong. Shouldn't this be inverted (i.e., !no_serve should pull in simple-http-server, not the inverse)?
| use xshell::Shell; | ||
|
|
||
| #[derive(Debug)] | ||
| #[expect(dead_code)] |
There was a problem hiding this comment.
nitpick: lolwut, reason for Positive plz?
question: Also, is it not possible to narrow this down to that specific variant? 🤔
There was a problem hiding this comment.
I thought I was going to write a positive check, but I didn't immediately think of one. I'm going to leave it for now, but will move the expect.
cwfitzgerald
force-pushed
the
cw/check-feature-deps
branch
from
f995930 to
8ec7233
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #6981
Simple check that ensures that a given set of features on a crate does/doesn't depend on a given crate. Should be pretty self-explanatory
Found #7040 through this.