Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add namespace prefix to lazily-loaded data object #84

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Add namespace prefix to lazily-loaded data object #84

wants to merge 2 commits into from

Conversation

ateucher
Copy link
Contributor

Description

Add namespace prefix to service_map data object as it's not in the package namespace.

Related Issue

Fixes #83

@ateucher
Copy link
Contributor Author

Errors in CI appear to not be from these changes, but due to auth to minio, maybe because I'm on a fork?

<paws_error/http_403/http_400/http_error/error/condition>
Error: Error: InvalidAccessKeyId (HTTP 403). The AWS Access Key Id you provided does not exist in our records.
Backtrace:
    ▆
 1. └─sixtyfour:::buckets_empty() at test-files.R:4:1
 2.   └─sixtyfour::aws_buckets() at tests/testthat/helper-minio.R:14:3
 3.     └─con_s3fs()$dir_info(refresh = TRUE, ...) at sixtyfour/R/bucket.R:327:3
 4.       └─private$.s3_bucket_ls(refresh)
 5.         └─s3fs:::retry_api_call(...)
 6.           └��base::tryCatch(...)
 7.             └─base (local) tryCatchList(expr, classes, parentenv, handlers)
 8.               └─base (local) tryCatchOne(...)
 9.                 └─value[[3L]](cond)

@sckott
Copy link
Member

sckott commented Jan 29, 2025

thanks @ateucher i'll check

@sckott
Copy link
Member

sckott commented Jan 29, 2025

looks like the MINIO_* env vars are not being picked up on ubuntu runs. weird. but they were picked up in other runs on the same branch.

@ateucher
Copy link
Contributor Author

I'm not sure if they are? empty in this macos run: https://github.com/getwilds/sixtyfour/actions/runs/13039241629/job/36377038930?pr=84#step:2:17

The minio tests are skipped on macos and Windows right?

@sckott
Copy link
Member

sckott commented Jan 31, 2025

You're right, minio and localstack are only run on linux CI's

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

service_map dataset is not in the package namespace, making aws_billing() unable to be used in another package
2 participants
@ateucher @sckott