-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
playing with child qmd files as rules #38
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I LOVE this! Full support, I think the implementation is right. I say ship it.
Thanks @seankross - Let me know what you think @tefirman |
p.s. I can't ship this as is, as this is just for one chapter. I'll do the rest adding to this PR, then can merge once its all set |
- instead of callouts use _variables.yml file to define rules - and combination of bootstrap badge + text of rule - provides more flexiblity in where rules can be placed (e..g, in lists) - most rules were in lists so it would have been awkward to have callouts combined with lists
@seankross can you look at this again (see preview link above)? I changed my mind about how to organize and display rules. callouts were kinda cool but take up a lot of space and have to be on their own lines (can't be in a list, etc.) and most of of our rules are naturally falling within a markdown list of things, so after a bit of trial and error, looks like quarto I've reworked the rules using
![]() Thoughts? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I like this too! Full endorsement and full speed ahead.
Thanks Sean, merging and we'll continue to iterate from here |
Description
Per our conversations, playing here with using child .qmd files to organize rules that we want to track/use/etc.
Related Issue
#37
Example
I've only done this in one chapter: Package maintenance, open that up and scroll down towards the bottom.
Testing
N/A
Discussion
We could not use callouts too. We could instead do:
Advantages of callouts:
Disadvantages of callouts:
In terms of machine reading, e.g.,
That's just a quick example in R, could do in python too.