Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incorporate SDLC best practices content #35

Merged
merged 1 commit into from
Aug 5, 2024
Merged

Conversation

sckott
Copy link
Member

@sckott sckott commented Jul 31, 2024

fixes #34

I've attempted feathering in the SDLC best practices content here into the guide. Do suggest different approaches if you think other things would work better.

Notes on each section from the SDLC best practices document:

I've added a new section listing the badges and their statuses https://deploy-preview-35--monumental-cassata-2f9bb7.netlify.app/conventions#statuses - Idea then being to link to this section whenever we mention a status type so that readers can click through to understand what e.g., Experimental means

@sckott sckott requested a review from seankross July 31, 2024 20:32
@sckott sckott marked this pull request as draft July 31, 2024 20:32
@sckott sckott marked this pull request as ready for review July 31, 2024 20:45
@sckott
Copy link
Member Author

sckott commented Jul 31, 2024

@seankross The permissions are borked b/c we changed the default permissions for actions across all of getwilds - so I need to make a change in main for the deploy preview yml file so the ping back works

Copy link

@seankross seankross left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Finally had time to go through all of this in detail. Looks great to me! Thanks so much Scott.

@sckott
Copy link
Member Author

sckott commented Aug 5, 2024

Great, thanks for looking at it

@sckott sckott merged commit a449485 into main Aug 5, 2024
1 of 2 checks passed
@sckott sckott deleted the sdlc-best-practices branch August 5, 2024 21:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fold in SDLC Best Practices
2 participants