-
Notifications
You must be signed in to change notification settings - Fork 93
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enable faster-than-sha1 build ids in LLVM, mold and binutils #1346
Comments
Any objection to changing this to "Enable BLAKE3 for build IDs in LLVM/MOLD/binutils"? If that's fine then this can be marked as complete once #4570 and #4575 land. MOLD was done in 61a0bae We can revisit XXH3 when support for it lands in a released version of binutils. My gut feeling is that we're getting 90-95% of the possible improvement of SHA1 -> XXH3 by using BLAKE3 and it might not be worth pursuing. If it's worth doing anywhere though it'll be binutils since the hashing there does the entire buffer in one thread. LLVM/MOLD are likely to not see as much improvement since they break the input into 1MB chunks and do them in parallel. |
Changes: - Re-enable building LLVM with PGO - Enable perf support in the JIT engine - Build MLIR-C library shared - Install the lld man page - Add "Solus $version-$release" to the Clang version - Disable building libcxx and llvm benchmarks (these weren't installed but were still built previously) - Ensure that the build-id is always set when writing ELF binaries and that it uses 20-byte output by default - Use zstd-compressed debug symbols by default for clang/lld/llvm-objcopy (for #1347) Addresses the LLVM part of #1346
Closing this as the scope of "faster build id generation" has now been achieved. #4603 is for tracking whether the next frontier of performance is worth pursuing. |
XXH3_64 bit is much faster than SHA-1.
EDIT:
The text was updated successfully, but these errors were encountered: