Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enhance SAML2: support HTTP-POST binding for idp SingleSignOnService #15876

Closed
ywmail opened this issue Nov 30, 2019 · 1 comment
Closed

Enhance SAML2: support HTTP-POST binding for idp SingleSignOnService #15876

ywmail opened this issue Nov 30, 2019 · 1 comment
Labels
Component: Auth

Comments

@ywmail
Copy link

ywmail commented Nov 30, 2019

Summary

Our idp only take POST request for SAML Request, but python3-saml used by Sentry only support HTTP-POST for SSO Service. see:
SAML-Toolkits/python-saml#146

Motivation

Why should this be worked on? What problems or use cases does it solve or
improve?

Additional Context

Any other context or screenshots or API request payload/responses that you
pertain to the feature.
@BYK
Copy link
Member

BYK commented Oct 22, 2020

Closing this issue due to staleness. Feel free to comment here if you think we should still work on this.

@BYK BYK closed this as completed Oct 22, 2020
@github-actions github-actions bot locked and limited conversation to collaborators Dec 17, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
Component: Auth
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@BYK @ywmail