Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sentry wizard overrides nvm configuration #518

Open
troZee opened this issue Dec 15, 2023 · 4 comments
Open

Sentry wizard overrides nvm configuration #518

troZee opened this issue Dec 15, 2023 · 4 comments
Assignees

Comments

@troZee
Copy link

troZee commented Dec 15, 2023

Environment

MacOS

Steps to Reproduce

  1. Install sentry wizard
  2. run nvm ls
  3. run nvm use 18.12.0
  4. run nvm current

Expected Result

sentry-wizard should not install node globally, which overrides nvm settings

Actual Result

If the node is installed, we should use the currently installed node.

➜  ~ brew uninstall node
Error: Refusing to uninstall /opt/homebrew/Cellar/node/21.3.0
because it is required by sentry-wizard, which is currently installed.
You can override this and force removal with:
  brew uninstall --ignore-dependencies node

After doing that

➜  ~ brew uninstall sentry-wizard 
Uninstalling /opt/homebrew/Cellar/sentry-wizard/3.19.0... (8,341 files, 47.8MB)
➜  ~ brew uninstall node         
Uninstalling /opt/homebrew/Cellar/node/21.3.0... (2,233 files, 63.5MB)
➜  ~ 

Everything works fine

@getsantry getsantry bot moved this to Waiting for: Product Owner in GitHub Issues with 👀 Dec 15, 2023
@Lms24
Copy link
Member

Lms24 commented Dec 15, 2023

@romtsn I believe this is related to the brew target. Would you mind taking a look at this issue?

@getsantry getsantry bot removed the status in GitHub Issues with 👀 Dec 15, 2023
@romtsn romtsn self-assigned this Dec 18, 2023
@romtsn
Copy link
Member

romtsn commented Dec 18, 2023

@Lms24 Sure, looks like we have to write a custom requirement that checks for an existing Node version and uses it, or otherwise installs the one from brew. The min supported Node version by the wizard is at 14.18 now, right?

@Lms24
Copy link
Member

Lms24 commented Dec 18, 2023

The min supported Node version by the wizard is at 14.18 now, right?

@romtsn yup. We might bump it in the future given Node 14 is EOL since a while but right now, it's >=1418.0.

Copy link

github-actions bot commented Jan 9, 2024

This issue has gone three weeks without activity. In another week, I will close it.

But! If you comment or otherwise update it, I will reset the clock, and if you label it Status: Backlog or Status: In Progress, I will leave it alone ... forever!


"A weed is but an unloved flower." ― Ella Wheeler Wilcox 🥀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: No status
Development

No branches or pull requests

3 participants