Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wizard project selection "glitches" when moving the arrow up #484

Closed
lucas-zimerman opened this issue Oct 26, 2023 · 9 comments
Closed

Wizard project selection "glitches" when moving the arrow up #484

lucas-zimerman opened this issue Oct 26, 2023 · 9 comments

Comments

@lucas-zimerman
Copy link
Contributor

Environment

-Latest version of wizard.

  • Windows 11
  • VS Code - Powershell terminal.

Steps to Reproduce

on the option of selecting the project, scroll down.
then scroll up and it'll start to mark multiple projects as selected.

I also noticed that at first it didn't happen when I was using on my main display (2k resolution), but it started to break once I tried it on a 1080p display, and continued broken even after moving to the 2k monitor

Not broken video:
https://github.com/getsentry/sentry-wizard/assets/8229322/a5d17894-ca6d-4c43-a5b5-b37fac4f4598
Broken video:
https://github.com/getsentry/sentry-wizard/assets/8229322/2ed12990-616d-4803-8e9f-3faba42c8cd0

Expected Result

to only a single project to be marked as the selected one.

Actual Result

it seems to only happen when you move the arrow up.
image

BONUS POINTS:
Allow to search the project by typing the name of it, it's quite hard to find the correct project since the project names aren't sortedby their names but by the org's name

@getsantry getsantry bot moved this to Waiting for: Product Owner in GitHub Issues with 👀 Oct 26, 2023
@Lms24
Copy link
Member

Lms24 commented Oct 31, 2023

@lucas-zimerman I think this happens when the height of the terminal window is smaller than the "page height" of the project list. Does this bug disappear if you increase the terminal window height?

Currently, we configured clack to show 12 projects per page. Maybe we should reduce this to something between 5-8?

@lucas-zimerman
Copy link
Contributor Author

lucas-zimerman commented Nov 1, 2023

It seems to glitch when the terminal window size is around 1219x399 pixels
image
Resizing to fullscreen seems to fix it (note the top is just garbage of unchanged text on the buffer so its ok)
image

My suspicious is that the Wizard requires 16 vertical character lines available, anything lower than that seems to glitch the scroll and the list
image
image

By default on my VSCode I have 13 visible vertical character lines so it'll glitch on the small monitor, where on the larger monitor i have 16 vertical lines.

@getsantry getsantry bot moved this to Waiting for: Product Owner in GitHub Issues with 👀 Nov 1, 2023
@getsantry getsantry bot removed the status in GitHub Issues with 👀 Nov 3, 2023
@Lms24
Copy link
Member

Lms24 commented Nov 3, 2023

I wonder if we can detect the number of lines and adjust the sliding window/page size for the list accordingly

Copy link

This issue has gone three weeks without activity. In another week, I will close it.

But! If you comment or otherwise update it, I will reset the clock, and if you label it Status: Backlog or Status: In Progress, I will leave it alone ... forever!


"A weed is but an unloved flower." ― Ella Wheeler Wilcox 🥀

@lucas-zimerman
Copy link
Contributor Author

image It seems to be also happening on MacOS

@Lms24 Lms24 reopened this Dec 6, 2023
@Lms24
Copy link
Member

Lms24 commented Dec 6, 2023

bad stalebot 😠

hmm yeah I still don't know how to fix this other than detecting the available lines or making the window smaller

@Lms24
Copy link
Member

Lms24 commented Dec 6, 2023

backlogging for now but don't have time to look into it in greater detail

@lucas-zimerman
Copy link
Contributor Author

this is an issue with the library itself, this could be fixed once bombshell-dev/clack#174 is merged.

@Lms24
Copy link
Member

Lms24 commented Dec 10, 2024

Closing as project selection has been moved to the in-browser login flow

@Lms24 Lms24 closed this as completed Dec 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Archived in project
Development

No branches or pull requests

2 participants