-
-
Notifications
You must be signed in to change notification settings - Fork 57
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Wizard project selection "glitches" when moving the arrow up #484
Comments
@lucas-zimerman I think this happens when the height of the terminal window is smaller than the "page height" of the project list. Does this bug disappear if you increase the terminal window height? Currently, we configured clack to show 12 projects per page. Maybe we should reduce this to something between 5-8? |
I wonder if we can detect the number of lines and adjust the sliding window/page size for the list accordingly |
This issue has gone three weeks without activity. In another week, I will close it. But! If you comment or otherwise update it, I will reset the clock, and if you label it "A weed is but an unloved flower." ― Ella Wheeler Wilcox 🥀 |
bad stalebot 😠 hmm yeah I still don't know how to fix this other than detecting the available lines or making the window smaller |
backlogging for now but don't have time to look into it in greater detail |
this is an issue with the library itself, this could be fixed once bombshell-dev/clack#174 is merged. |
Closing as project selection has been moved to the in-browser login flow |
Environment
-Latest version of wizard.
Steps to Reproduce
on the option of selecting the project, scroll down.
then scroll up and it'll start to mark multiple projects as selected.
I also noticed that at first it didn't happen when I was using on my main display (2k resolution), but it started to break once I tried it on a 1080p display, and continued broken even after moving to the 2k monitor
Not broken video:
https://github.com/getsentry/sentry-wizard/assets/8229322/a5d17894-ca6d-4c43-a5b5-b37fac4f4598
Broken video:
https://github.com/getsentry/sentry-wizard/assets/8229322/2ed12990-616d-4803-8e9f-3faba42c8cd0
Expected Result
to only a single project to be marked as the selected one.
Actual Result
it seems to only happen when you move the arrow up.
![image](https://private-user-images.githubusercontent.com/8229322/278442201-e3b8e9da-8a00-49a2-be29-085be8edd2e0.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3Mzk0MzU5MzEsIm5iZiI6MTczOTQzNTYzMSwicGF0aCI6Ii84MjI5MzIyLzI3ODQ0MjIwMS1lM2I4ZTlkYS04YTAwLTQ5YTItYmUyOS0wODViZThlZGQyZTAucG5nP1gtQW16LUFsZ29yaXRobT1BV1M0LUhNQUMtU0hBMjU2JlgtQW16LUNyZWRlbnRpYWw9QUtJQVZDT0RZTFNBNTNQUUs0WkElMkYyMDI1MDIxMyUyRnVzLWVhc3QtMSUyRnMzJTJGYXdzNF9yZXF1ZXN0JlgtQW16LURhdGU9MjAyNTAyMTNUMDgzMzUxWiZYLUFtei1FeHBpcmVzPTMwMCZYLUFtei1TaWduYXR1cmU9NmNlZmEwNzQ0MjhhMTc4ZmI1NDhmZWZlMzhmN2NjM2MzNTEzNWVhODEwZmE5MjVhZmVkYmE3M2NkNzE2YTg0YSZYLUFtei1TaWduZWRIZWFkZXJzPWhvc3QifQ.tLnYyfRH47rdGHFxL06RY7rdZEO5McHITFdJulD6hCU)
BONUS POINTS:
Allow to search the project by typing the name of it, it's quite hard to find the correct project since the project names aren't sortedby their names but by the org's name
The text was updated successfully, but these errors were encountered: