From 26ae6b4a112241c9a21fb3035fbc195da87cdaf2 Mon Sep 17 00:00:00 2001
From: Francesco Novy <francesco.novy@sentry.io>
Date: Wed, 29 Jan 2025 10:41:34 +0100
Subject: [PATCH] ref(core): Streamline `SentryError` class

We did some funky stuff in there that does not seem necessary and can even lead to issues.

Fixes https://github.com/getsentry/sentry-javascript/issues/15214.
---
 packages/core/src/client.ts            | 7 +++----
 packages/core/src/utils-hoist/error.ts | 8 --------
 2 files changed, 3 insertions(+), 12 deletions(-)

diff --git a/packages/core/src/client.ts b/packages/core/src/client.ts
index 7334b2d294ed..805596a8a855 100644
--- a/packages/core/src/client.ts
+++ b/packages/core/src/client.ts
@@ -903,11 +903,10 @@ export abstract class Client<O extends ClientOptions = ClientOptions> {
         if (DEBUG_BUILD) {
           // If something's gone wrong, log the error as a warning. If it's just us having used a `SentryError` for
           // control flow, log just the message (no stack) as a log-level log.
-          const sentryError = reason as SentryError;
-          if (sentryError.logLevel === 'log') {
-            logger.log(sentryError.message);
+          if (reason instanceof SentryError && reason.logLevel === 'log') {
+            logger.log(reason.message);
           } else {
-            logger.warn(sentryError);
+            logger.warn(reason);
           }
         }
         return undefined;
diff --git a/packages/core/src/utils-hoist/error.ts b/packages/core/src/utils-hoist/error.ts
index 622aaff9cf80..5ae28093a8bf 100644
--- a/packages/core/src/utils-hoist/error.ts
+++ b/packages/core/src/utils-hoist/error.ts
@@ -2,9 +2,6 @@ import type { ConsoleLevel } from '../types-hoist';
 
 /** An error emitted by Sentry SDKs and related utilities. */
 export class SentryError extends Error {
-  /** Display name of this error instance. */
-  public name: string;
-
   public logLevel: ConsoleLevel;
 
   public constructor(
@@ -13,11 +10,6 @@ export class SentryError extends Error {
   ) {
     super(message);
 
-    this.name = new.target.prototype.constructor.name;
-    // This sets the prototype to be `Error`, not `SentryError`. It's unclear why we do this, but commenting this line
-    // out causes various (seemingly totally unrelated) playwright tests consistently time out. FYI, this makes
-    // instances of `SentryError` fail `obj instanceof SentryError` checks.
-    Object.setPrototypeOf(this, new.target.prototype);
     this.logLevel = logLevel;
   }
 }