[v9] Parent-child relationship for the PlatformExceptions and Cause

[krystofwoldrich]

Description

The Dart/Flutter SDK currently supports PlatformExceptions and ExceptionCause.

Related links

• sentry-dart/flutter/lib/src/event_processor/platform_exception_event_processor.dart

  Line 5 in 681136b

  class PlatformExceptionEventProcessor implements EventProcessor {

• sentry-dart/dart/lib/src/exception_cause_extractor.dart

  Line 32 in 681136b

  abstract class ExceptionCauseExtractor<T> {

• Sentry RFC https://github.com/getsentry/rfcs/blob/main/text/0079-exception-groups.md#example-event
• Example JS impl feat: Support AggregateErrors in LinkedErrors integration sentry-javascript#8463

Notes

• I'm not aware of how used or not the AggregateErrors are. After a quick search doesn't seem too common.
• Implementing this might likely change grouping so it should be done in a major version.
• Dart could add the parent-child relationship to the linked errors as described in the RFC.

Related

Preview Give feedback

1. With chained errors, which one counts as the main one? sentry#64088
   +0
2. Improve exception grouping on Android for RuntimeExceptions sentry-java#3184
   +0

Tasks

Preview Give feedback

1. Implement parent-child relationship for PlatformException
2. Implement parent-child relationship for ExceptionCause

Example PlatformException chaining

[ueman]

This is coming out of a package and it's not an error from Dart or Flutter. The package is also not particularly popular.

[krystofwoldrich]

@ueman Thank you for the message, I've missed that, in that case, it doesn't make sense to add it to the SDK.

We could still add the parent-child relationship for the PlatformExceptions and Cause as described in the RFC.

[krystofwoldrich]

After a closer look, it looks like the dart SDK is sending the native and dart exceptions in the opposite order than the specification says.

Dart send: Newer -> older. (Dart -> native) ->

sentry-dart/flutter/lib/src/event_processor/android_platform_exception_event_processor.dart

Lines 100 to 101 in 8e4eeb3

	...?event.exceptions,
	...jvmExceptions,

Specs: Older -> newer. -> https://develop.sentry.dev/sdk/event-payloads/exception/

[marandaneto]

After a closer look, it looks like the dart SDK is sending the native and dart exceptions in the opposite order than the specification says.

Dart send: Newer -> older. (Dart -> native) ->

sentry-dart/flutter/lib/src/event_processor/android_platform_exception_event_processor.dart

Lines 100 to 101 in 8e4eeb3

	...?event.exceptions,
	...jvmExceptions,

Specs: Older -> newer. -> develop.sentry.dev/sdk/event-payloads/exception

Be sure before changing the order, I know that the BE reverses the list.

[krystofwoldrich]

@marandaneto Thank you I will check that, don't want to break it.

[denrase]

@krystofwoldrich Do we know if the be is changing order here?

[krystofwoldrich]

The parent-child linking doesn't rely on order, but requires explicitly set exception_id and parent_id.