Aerospike sink: Add transactionally consistent denormalization #2437
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is based on the aerospike resumability branch.
I added a configuration to the aerospike sink table config, which specifies
where to write the denormalized version of that table to, called
write_denormalized_to.All tables will also be written in their raw form.
Resumability is implemented using a two-phase approach:
First, write the denormalized tables, then write a txid for the denorm tables
Second, write the lookup tables, then write a txid for the lookup tables
If we go down between writing the denorm txid and the lookup txid, we skip denorm until we reach the lookup txid.