Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Define tags as semi-private #15

Open
geospatial-jeff opened this issue May 13, 2020 · 0 comments
Open

Define tags as semi-private #15

geospatial-jeff opened this issue May 13, 2020 · 0 comments

Comments

@geospatial-jeff
Copy link
Owner

geospatial-jeff commented May 13, 2020

Made some improvements with #4 and #9 but I'm still not a huge fan.

I think it would be best to switch tags to semi-private attributes and expose important metadata through properties like here. At minimum we should have properties for the rasterio profile. A few reasons:

  1. I don't think most users care about the metadata contained on each Tag object (or even care about all of the defined tags)
  2. Keeping Tag defined on the IFD still resolves Define explicit IFD attributes for supported tags #9.
  3. Properties of course will be more user friendly to use (ifd.width instead of ifd.ImageWidth.value).
  4. Making Tag semi-private prevents confusion (ex. ifd.Compression vs ifd.compression is confusing)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant