Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Port the code to python3 and/or python2-3 compatible code #155

Closed
jorgejesus opened this issue Aug 6, 2017 · 10 comments
Closed

Port the code to python3 and/or python2-3 compatible code #155

jorgejesus opened this issue Aug 6, 2017 · 10 comments
Assignees
Milestone

Comments

@jorgejesus
Copy link
Member

Current code is only python2 compatible.

Possibility:

  • Change code to python3 and only use python3
  • Change code to be python2.7 and python3.3 compatible
  • PyPy ??? (https://pypy.org/) (this could be hard)

Tools/Docs:
http://python-future.org/
Testing different possibility with tox:
https://tox.readthedocs.io/en/latest/

@jorgejesus
Copy link
Member Author

Extra docs and explanation how to processed with extra tools
https://docs.python.org/3/howto/pyporting.html

@justb4
Copy link
Member

justb4 commented Aug 9, 2017

Welcomed. I just did the reverse: Python3 project also supporting Py2: schettino72/sqla_yaml_fixtures#1 what especially helped is more thorough tests, CI and code coverage (even went to 100% code coverage, but ok small project). GHC has some tests now but not exhaustive, so we should work on that as well to make the transition smoother.

@tomkralidis tomkralidis added this to the Version 0.4.0 milestone Dec 8, 2017
@justb4 justb4 modified the milestones: Version 0.4.0, Version 0.5.0 Mar 5, 2018
@justb4 justb4 modified the milestones: Version 0.5.0, Version 0.6.0 Nov 15, 2018
@justb4 justb4 modified the milestones: Version 0.6.0, Version 0.7.0 Jun 11, 2019
@tomkralidis
Copy link
Member

Update: following discussion on Gitter, given the 0.6.0 release we will update master to be Python 3 only moving forward.

tomkralidis added a commit to tomkralidis/GeoHealthCheck that referenced this issue Jun 12, 2019
@justb4
Copy link
Member

justb4 commented Aug 31, 2019

@tomkralidis @borrob @jorgejesus
Like many projects as Django (2.0 is PY3 only) etc, I would prefer not to have simultaneous Py2 and Py3 support, given that:

  • Py2 will be EOL very soon (less than a year)
  • maintenance: we already have limited human resources
  • many users (more and more) are deploying with Docker

Like with Stetl in a similar PR we decided to:

  • bring out one last Py2 release (and Docker Image)
  • make a branch of that release, for urgent fixes only
  • bring out fresh Py3-only version

@borrob
Copy link
Collaborator

borrob commented Sep 2, 2019

I'm working on the conversion to python3 (but somehow I can't assign this task to myself). I'm using the version that comes standard with buster (I believe that is 3.7.2), but so far I think any '3' version will do.

I am aiming for a py3-only version, so as to keep the code as clean and simple as possible.

@tomkralidis
Copy link
Member

I've added you as a collaborator so you should be able to assign yourself now - can you let me know if it works?

Agree, py3-only version. We can cut a last released for Python 2 support when ready to merge the Python 3 work.

@justb4 justb4 assigned borrob and unassigned borrob Sep 2, 2019
@justb4
Copy link
Member

justb4 commented Sep 2, 2019

Sorry did not see this last comment. @borrob should be able to assign himself as test. great! we'll be there to support.

@borrob borrob self-assigned this Sep 3, 2019
@borrob
Copy link
Collaborator

borrob commented Sep 16, 2019

As a quick update: still working on the conversion. I think I addressed most of the issues now and currently I am fixing the docker build (that is having issues with importing).

@borrob
Copy link
Collaborator

borrob commented Oct 25, 2019

Pull Request #280 is out for review. That should bring the codebase to python3.

@justb4 justb4 modified the milestones: Version 0.7.0, Version 0.8.0 Oct 27, 2019
@borrob
Copy link
Collaborator

borrob commented Dec 5, 2019

Pull request #280 is merged to master, so I am closing this issue :)

@borrob borrob closed this as completed Dec 5, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants