No copy matrix args #2
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1. Make function prototypes be prototypes. 2. Fix various bad initializers (missing braces, initialise from non-const) 3. Sprinkle some attributes around, const since most functions are totally pure functions, one unused and one noreturn
brings first 6 passes down from 28s to 23s on westmere chip, bottleneck changes from mrMul to main: 31.27% gloss gloss [.] main 27.95% gloss gloss [.] mrMul 19.61% gloss gloss [.] sceneObjectBoxIntersectRay 14.29% gloss gloss [.] sceneObjectUnitPlaneIntersectRay
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To be applied after or instead of previous pull req.