Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Proposed new gorule-0000064 TreeGrafter IEAs should be filtered for GO reference species #2273

Closed
cmungall opened this issue Mar 27, 2024 · 5 comments
Assignees

Comments

@cmungall
Copy link
Member

cmungall commented Mar 27, 2024

Proposed text:

If an annotation is an IEA to GO_REF:0000118 and the taxon is not in the GO reference species list (i.e 143 species for which we get IBAs), then filter out.

Ideally this would be implemented upstream at EBI-GOA

We have a goref for tree grafter #2130 : GO_REF:0000118

@pgaudet pgaudet changed the title Proposed GO RULE: TreeGrafter IEAs should be filtered for GO reference species Proposed new gorule-0000064 TreeGrafter IEAs should be filtered for GO reference species Mar 27, 2024
pgaudet added a commit that referenced this issue Mar 27, 2024
pgaudet added a commit that referenced this issue Mar 27, 2024
@pgaudet
Copy link
Contributor

pgaudet commented Mar 28, 2024

Test errors are correctly being picked up.

@pgaudet
Copy link
Contributor

pgaudet commented May 6, 2024

Working as expected.

@pgaudet pgaudet closed this as completed May 6, 2024
@pgaudet pgaudet reopened this Jul 26, 2024
@pgaudet
Copy link
Contributor

pgaudet commented Jul 26, 2024

Hi @mugitty

Tests are not failing - or not being reported in error reports.

@mugitty
Copy link
Contributor

mugitty commented Jul 26, 2024

@pgaudet, tests are failing for gorule 64 in snapshot:
http://snapshot.geneontology.org/reports/assigned-by-TreeGrafter-report.html#gorule-0000064
...
gorule-0000064

TreeGrafter IEAs should be filtered for GO reference species

total: 10050

messages

ERROR - Violates GO Rule:GORULE:0000064: TreeGrafter ('GO_REF:0000118') IEAs should be filtered for GO reference species--`SGD S000005513 YOL153C involved_in GO:0051603 GO_REF:0000118 IEA PANTHER:PTN000110795 P Blocked reading frame, contains two in-frame stops in translation YOL153C protein taxon:559292 20240610 TreeGrafter UniProtKB:P0C155 `
ERROR - Violates GO Rule:GORULE:0000064: TreeGrafter ('GO_REF:0000118') IEAs should be filtered for GO reference species--`SGD S000005513 YOL153C located_in GO:0000328 GO_REF:0000118 IEA PANTHER:PTN000110795 C Blocked reading frame, contains two in-frame stops in translation YOL153C protein taxon:559292 20240610 TreeGrafter UniProtKB:P0C155 `

...

In the errors.gaf file processing, we have the following:
! FAILS GORULE:0000064 - TEST 1 - human protein
UniProtKB A0A140VJL9 A0A140VJL9 involved_in GO:0006783 GO_REF:0000118 IEA PANTHER:PTHR11458:SF0 P GORULE_TEST:0000064-1 protein taxon:9606 20240201 TreeGrafter
! FAILS GORULE:0000064 - TEST 2 - Drosophila protein
UniProtKB Q8IH53 Hmbs involved_in GO:0006783 GO_REF:0000118 IEA PANTHER:PTHR11557:SF0 P GORULE_TEST:0000064-2 protein taxon:7227 20240201 TreeGrafter

Both test cases are reported as failing in 'GORULE violations assigned by TreeGrafter'
GORULE violations assigned by TreeGrafter

...

MESSAGES
gorule-0000064

TreeGrafter IEAs should be filtered for GO reference species

total: 2

messages

ERROR - Violates GO Rule:GORULE:0000064: TreeGrafter ('GO_REF:0000118') IEAs should be filtered for GO reference species--`UniProtKB A0A140VJL9 A0A140VJL9 involved_in GO:0006783 GO_REF:0000118 IEA PANTHER:PTHR11458:SF0 P GORULE_TEST:0000064-1 protein taxon:9606 20240201 TreeGrafter `
ERROR - Violates GO Rule:GORULE:0000064: TreeGrafter ('GO_REF:0000118') IEAs should be filtered for GO reference species--`UniProtKB Q8IH53 Hmbs involved_in GO:0006783 GO_REF:0000118 IEA PANTHER:PTHR11557:SF0 P GORULE_TEST:0000064-2 protein taxon:7227 20240201 TreeGrafter `

....

Am I missing something?

@kltm kltm moved this to Clearing - needs testing in GORULES (low-hanging fruit) Aug 22, 2024
@pgaudet
Copy link
Contributor

pgaudet commented Aug 27, 2024

Working

@pgaudet pgaudet closed this as completed Aug 27, 2024
@pgaudet pgaudet moved this from Clearing - needs testing to Done in GORULES (low-hanging fruit) Aug 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Development

No branches or pull requests

3 participants