Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

standardize use of underscore in gorel term names #12156

Closed
tberardini opened this issue Nov 9, 2015 · 3 comments
Closed

standardize use of underscore in gorel term names #12156

tberardini opened this issue Nov 9, 2015 · 3 comments

Comments

@tberardini
Copy link
Contributor

Moved from GO helpdesk.
http://jira.geneontology.org/browse/GO-681

Hi,

we noticed that the gorel file sometimes has underscores and sometimes spaces. Can we standardize? I prefer underscores as that is what we have been using so far.

Thanks

Val

coincident_with(...)", but the name of the term is "coincident with" (with a space). The extension code looks up using the ext. rel. term name not the ID.
For all the other relations the term name is the same as the ID, with underscore rather than spaces. eg.
id: has_direct_input
name: has_direct_input
Looking at the gorel file, it seems quite random. Some names have underscore and some have spaces.

@tberardini
Copy link
Contributor Author

Rama Balakrishnan (Inactive) added a comment - 03/Jan/15 9:39 PM

Val,
Thanks for bringing this up. I will alert the ontology editors about this issue.

Rama

@tberardini
Copy link
Contributor Author

@ValWood @cmungall Please close if this is no longer relevant. Thanks.

@dosumis
Copy link
Contributor

dosumis commented Nov 10, 2015

The relation names in ro.owl have been without underscores for some years now. You are just seeing this now becuase of work to harmonise gorel with relations used in the GO (full version) and RO. The higher level RO relations are used outside of OWL, so any change would require wider debate. I don't see any appetite for re-opening that.

The extension code looks up using the ext. rel. term name not the ID.

It should be switched to use the ID. No-one editing the ontology is going to assume that labels need to be stable for tracking purposes.

See also: geneontology/annotation_extensions#3

Duplicate with geneontology/annotation_extensions#51

@dosumis dosumis closed this as completed Nov 10, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants