Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Synonyms and alternate IDs as legitimate input #91

Open
kltm opened this issue Apr 18, 2014 · 6 comments
Open

Synonyms and alternate IDs as legitimate input #91

kltm opened this issue Apr 18, 2014 · 6 comments

Comments

@kltm
Copy link
Member

kltm commented Apr 18, 2014

From http://jira.geneontology.org/browse/GO-374


I open the Visualization form:
http://amigo.geneontology.org/amigo/visualize

I put the GO term "GO:0001589" into the search field, nothing else.

I click "visualize".

Then the error appears.

The URL that finally produced the error was:
http://amigo.geneontology.org/visualize?format=png&term_data=GO%3A0001589&term_data_type=string&mode=amigo&inline=false


This would require either a multipass resolution mechanism, or (preferably) a generalized personality hinted method of recovering a document (or documents) when the ID is definitely known (i.e. not a search) using the manager. Basically a more full-featured version of set_id().

@kltm
Copy link
Member Author

kltm commented Apr 18, 2014

Actually, in this case, the issue is with the perl GOlr client; since it's serial, a two-pass system may be easier to handle than a more complicated manager.

@kltm
Copy link
Member Author

kltm commented Apr 18, 2014

The error message in visualize is rather misleading in this case anyways. Need to make it clearer.

@kltm kltm changed the title Use synonyms and alternate IDs as legitimate input visualize Use synonyms and alternate IDs as legitimate input May 7, 2014
@kltm kltm added this to the 2.3 milestone May 7, 2014
@kltm
Copy link
Member Author

kltm commented May 7, 2014

Generalizing this to be not just about visualize (change in title), since you can find this issue cropping up places like the alternate ID field when looking at ontology terms--they link to nothing since there is no term by that ID.

One could deal with this by having a few new fields; we could redefine as the following:

  • id: the internal ID that is not generally exposed to users; in most cases it would be the
  • annotation_class/canonical_id: the main ID to which people are annotating to, etc. (check with @cmungall)
  • alternate_id/synonyms: other IDs that are used for the item
  • annotation_class_union: an internal-only searchable field (union of the above) that would be used as the main resolution field; would only work if guaranteed to be disjoint
  • similar might be applicable to annotation docs, etc., but probably not as important
    This is rather more than what we have, but it would allow for an internally clean and externally transparent solution to this irritation.

Fixing would involve monkeying with the loader, so pushing to 2.3 for now.

@kltm kltm changed the title Use synonyms and alternate IDs as legitimate input Synonyms and alternate IDs as legitimate input May 7, 2014
@kltm kltm modified the milestones: 2.3, 2.4 Aug 26, 2015
kltm added a commit that referenced this issue Jan 7, 2016
… tables by having a handler /not/ do anything to the contents; technically fixes #289, reminds us of the more important #91
@kltm kltm modified the milestones: 2.4, 2.5 Mar 2, 2016
@cmungall
Copy link
Member

I'm not totally sure #476 should have been merged in here, I don't fully understand this ticket but I may be different from #476?

@kltm
Copy link
Member Author

kltm commented Mar 20, 2018

Whoops, undone. I think I might have had another ticket in mind, but I forget now...

@kltm
Copy link
Member Author

kltm commented May 17, 2019

Noting some concern about this from @suzialeksander

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants